Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Bluetooth-related function calls up to host/keyboard level #18274

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Move Bluetooth-related function calls up to host/keyboard level #18274

merged 5 commits into from
Sep 7, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 5, 2022

Description

  • Removed some useless MOUSE_ENABLE ifdefs in Bluefruit LE code (which caused issues with the main change here anyway)
  • Fixed Bluefruit LE device name being in quotes (due to recent USB string define changes)
  • Extracted Bluetooth-related code out of lufa.c and into host.c/keyboard.c so it can be platform-agnostic

Tested on a Pro Micro and Proton-C with both RN42 and BluefruitLE drivers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 5, 2022 12:17
@fauxpark fauxpark marked this pull request as ready for review September 6, 2022 07:26
@zvecr zvecr merged commit f7d2b00 into qmk:develop Sep 7, 2022
@fauxpark fauxpark deleted the bluetooth-move-to-host-level branch September 7, 2022 20:00
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Move Bluetooth-related function calls up to host/keyboard level (qmk#…
8f852fd 
…18274)

* Move Bluetooth-related function calls up to host/keyboard level

* Remove pointless set_output() call

* Move bluetooth (rn42) init to end of keyboard_init()

* Enable SPI/UART for ChibiOS targets

* Some more slight tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @tzarc @zvecr