Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs regarding cirque pinnacle attenuation #18279

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

preisi
Copy link
Contributor

@preisi preisi commented Sep 5, 2022

Description

With commit 5db705d the documentation for configuring the attenuation for the cirque pinnacle touchpad became out of date due to some code changes. This commit updates the docs accordingly to match the current code again.

Relevant code section:

#define EXTREG__TRACK_ADCCONFIG 0x0187
// ADC-attenuation settings (held in BIT_7 and BIT_6)
// 1X = most sensitive, 4X = least sensitive
# define EXTREG__TRACK_ADCCONFIG__ADC_ATTENUATE_MASK 0xC0
# define EXTREG__TRACK_ADCCONFIG__ADC_ATTENUATE_1X 0x00
# define EXTREG__TRACK_ADCCONFIG__ADC_ATTENUATE_2X 0x40
# define EXTREG__TRACK_ADCCONFIG__ADC_ATTENUATE_3X 0x80
# define EXTREG__TRACK_ADCCONFIG__ADC_ATTENUATE_4X 0xC0
#define EXTREG__TRACK_ADCCONFIG_DEFVAL 0x4E

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

With commit 5db705d the documentation
for configuring the attenuation for the cirque pinnacle touchpad became
out of date due to some code changes. This commit updates the docs
accordingly to match the current code again.
@drashna drashna requested a review from a team September 8, 2022 01:46
@drashna drashna merged commit 55c637f into qmk:develop Sep 12, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants