Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage use of ENCODER_MAP at keyboard level #18286

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Discourage use of ENCODER_MAP at keyboard level #18286

merged 2 commits into from
Sep 6, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 6, 2022 •
edited
Loading

Description

While lint currently isnt throwing errors, at least the docs can have some more words to prevent.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team September 6, 2022 06:26
@drashna drashna requested a review from a team September 6, 2022 15:29
fauxpark
fauxpark approved these changes Sep 6, 2022
View reviewed changes
docs/feature_encoders.md Outdated Show resolved Hide resolved
@zvecr @fauxpark
Update docs/feature_encoders.md
49ef3ff 
Co-authored-by: Ryan <fauxpark@gmail.com>
@zvecr zvecr merged commit 60cac6d into qmk:master Sep 6, 2022
spidey3 added a commit that referenced this pull request Sep 6, 2022
@spidey3 @zvecr
@fauxpark @noroadsleft
Resolve conflict merging master to develop (#18297)
a4d1d8b 
* Discourage use of ENCODER_MAP at keyboard level (#18286)

* Discourage use of ENCODER_MAP at keyboard level

* Update docs/feature_encoders.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>

* Fungo rev1: fix QMK Configurator key sequence (#18293)

* info.json: correct JSON syntax; friendly formatting

* info.json: fix key sequence

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
csrazvan added a commit to csrazvan/qmk_firmware that referenced this pull request Sep 8, 2022
@csrazvan
Merge remote-tracking branch 'upstream/master'
8f7ded9 
* upstream/master: (451 commits)
  Add Iris Rev. 6b (qmk#18307)
  GeonWorks Frog Mini Hotswap Layout Rework (qmk#18305)
  Update Iris VIA configuration (qmk#18306)
  [Keyboard] Wearhaus66 correct matrix (qmk#18284)
  enable RGB matrix effects for drop ctrl (qmk#18291)
  [Keymap] removed else in numlock led if statement (qmk#18304)
  added a new kprepublic/bm40hsrgb keymap called dan (qmk#18301)
  Delete my keymaps (qmk#18302)
  keymaps/stapelberg: keypad layer for multimedia keys, wake on escape (qmk#18295)
  Fungo rev1: fix QMK Configurator key sequence (qmk#18293)
  Discourage use of ENCODER_MAP at keyboard level (qmk#18286)
  Mars 6.5 Layout Additions (qmk#18282)
  Remove use of legacy keycode (qmk#18281)
  EU ISOlation: fix QMK Configurator key sequence (qmk#18272)
  Fix compilation error for GH60 satan HHKB 7u layout (qmk#18250)
  dyz60_hs Layout Additions (qmk#18261)
  Fix a couple of boards still using `usb.device_ver` (qmk#18258)
  Clean up data driven mappings syntax (qmk#18257)
  [Docs] Update 'Process Record' according to the code (qmk#18209)
  [Keyboard] RS60 Rev2 change to eeprom emulation (qmk#18201)
  ...
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spidey3 @zvecr
@fauxpark @noroadsleft @ramonimbao
Resolve conflict merging master to develop (qmk#18297)
857d242 
* Discourage use of ENCODER_MAP at keyboard level (qmk#18286)

* Discourage use of ENCODER_MAP at keyboard level

* Update docs/feature_encoders.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>

* Fungo rev1: fix QMK Configurator key sequence (qmk#18293)

* info.json: correct JSON syntax; friendly formatting

* info.json: fix key sequence

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @fauxpark @ramonimbao
Discourage use of ENCODER_MAP at keyboard level (qmk#18286)
8d99d66 
* Discourage use of ENCODER_MAP at keyboard level

* Update docs/feature_encoders.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @fauxpark @nolanseaton
Discourage use of ENCODER_MAP at keyboard level (qmk#18286)
3a385c3 
* Discourage use of ENCODER_MAP at keyboard level

* Update docs/feature_encoders.md

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark