Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DRIVER_LED_COUNT to {LED,RGB}_MATRIX_LED_COUNT #18399

Merged
merged 12 commits into from
Sep 23, 2022

Conversation

fauxpark
Copy link
Member

Description

Allows for this config define to be moved to info.json.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 18, 2022 11:21
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Sep 18, 2022
@fauxpark
Copy link
Member Author

Lint errors are unrelated.

☒ geekboards/macropad_v2: Layout "LAYOUT" has no "matrix" definition in either "info.json" or "<keyboard>.h"!
☒ spaceholdings/nebula12: Layout "LAYOUT_68_ansi" has no "matrix" definition in either "info.json" or "<keyboard>.h"!

@Kriechi
Copy link
Contributor

Kriechi commented Sep 18, 2022

@fauxpark how does this related to #18036 in any way by chance?

@fauxpark
Copy link
Member Author

The ws2812.h change would need to be updated (assuming this PR is merged first), other than that there is nothing else to do there.

@fauxpark fauxpark merged commit 36c4105 into qmk:develop Sep 23, 2022
@fauxpark fauxpark deleted the led-rgb-matrix-led-count branch September 23, 2022 12:46
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants