[Core] Serial-protocol: always clear receive queue on main half of split keyboard #18419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in order to flush out any spurious bytes or traffic that belongs to failed transactions send by the secondary half. This is save todo as the main half initiates every transaction and must never receive any data before sending a handshake.
KarlK90
changed the title
14 tasks
tzarc
approved these changes
Oct 3, 2022
|
My serial communication stopped working with this change. KB2040, full duplex |
|
Thanks for reporting this, I did try this out on rp2040s half-duplex and gd32vf103 in full-duplex operation. Obviously that was not enough, I'll investigate tomorrow as this is a problem with the PIO driver. |
|
@mike1808 I have a theory what could cause the problem. Can you try to remove this line and see if this fixes the issue? |
|
@KarlK90 that was it! It fixed it. |
14 tasks
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...in order to flush out any spurious bytes or traffic that belongs to failed transactions send by the secondary half. This is save todo as the main half initiates every transaction and must never receive any data before sending a handshake.
Tested with RP2040 and GD32VF103 splits.
Types of Changes
Issues Fixed or Closed by This PR
Checklist