Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect g_led_config generation #18431

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Fix incorrect g_led_config generation #18431

merged 2 commits into from
Sep 21, 2022

Conversation

fauxpark
Copy link
Member

Description

If neither LED Matrix nor RGB Matrix are enabled, but a g_led_config structure exists in the keyboard, this code will parse and re-generate it assuming RGB Matrix. With this change the g_led_config is not generated unless one of the two are enabled.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug python cli qmk cli command labels Sep 20, 2022
@fauxpark fauxpark requested a review from a team September 20, 2022 02:46
zvecr
zvecr reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/python/qmk/info.py Outdated Show resolved Hide resolved
@fauxpark @zvecr
Update lib/python/qmk/info.py
4ba3a3e 
Co-authored-by: Joel Challis <git@zvecr.com>
@fauxpark fauxpark requested a review from zvecr September 21, 2022 01:36
@zvecr zvecr merged commit 591701c into qmk:develop Sep 21, 2022
@fauxpark fauxpark deleted the fix-g-led-config-gen branch September 21, 2022 01:55
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Fix incorrect g_led_config generation (qmk#18431)
bf9a41e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr