Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mouse keys more consistently #18513

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Handle mouse keys more consistently #18513

merged 2 commits into from
Sep 29, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 28, 2022

Description

Pulls out all of the logic for handling mouse keycodes into a single function for more consistent behavior, and allows mouse keycodess to work, even if mousekeys is disabled.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 28, 2022 16:51
@github-actions github-actions bot added the core label Sep 28, 2022
@drashna drashna requested a review from a team September 28, 2022 18:03
@drashna drashna merged commit dbe214c into qmk:develop Sep 29, 2022
@drashna drashna deleted the mouse_keys branch September 29, 2022 17:50
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants