Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUFA: Consolidate report sending code #18629

Merged
merged 1 commit into from
Oct 15, 2022
Merged

LUFA: Consolidate report sending code #18629

merged 1 commit into from
Oct 15, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 7, 2022

Description

Noticed there was a fair bit of repetition here. Shaves off almost 100 bytes (tested with gh60/satan:default). Also looking into whether similar can be done for the other platforms.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 7, 2022 04:07
@drashna drashna requested a review from a team October 7, 2022 05:29
@spidey3 spidey3 merged commit 19e2dd7 into qmk:develop Oct 15, 2022
@fauxpark fauxpark deleted the lufa-dedupe-report-sending branch October 15, 2022 22:51
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
LUFA: Consolidate report sending code (qmk#18629)
87c874a
@fauxpark fauxpark mentioned this pull request Jan 16, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @spidey3