Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy keycodes, part 5 #18710

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Remove legacy keycodes, part 5 #18710

merged 3 commits into from
Oct 15, 2022

Conversation

fauxpark
Copy link
Member

Description

#18683

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Oct 14, 2022
@fauxpark fauxpark requested a review from a team October 14, 2022 02:40
@zvecr zvecr merged commit 5e4b076 into qmk:develop Oct 15, 2022
@fauxpark fauxpark deleted the remove-legacy-keycodes-5 branch October 15, 2022 22:20
This was referenced Oct 16, 2022
Merged
Merged
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Remove legacy keycodes, part 5 (qmk#18710)
3594830 
* `KC_SLCK` -> `KC_SCRL`
* `KC_NLCK` -> `KC_NUM`
jpskenn pushed a commit to jpskenn/qmk_firmware that referenced this pull request Nov 1, 2023
Remove legacy keycodes, part 5 (qmk#18710)
795e241
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 1, 2023
@jpskenn
Revert "Remove legacy keycodes, part 5 (qmk#18710)"
ea845b7 
This reverts commit 795e241.
jpskenn pushed a commit to jpskenn/qmk_firmware that referenced this pull request Nov 2, 2023
Remove legacy keycodes, part 5 (qmk#18710)
fc41351 
`KC_SLCK` -> `KC_SCRL`
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 4, 2023
@jpskenn
Remove legacy keycodes, part 5 (qmk#18710)
7a2bac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @zvecr @spidey3