-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Move Hillside out of handwired #18751
Conversation
cos i'm tired and can't read CI properly
bd6b6eb
to
bdf7c9f
Compare
Are the remaining CI fails a CI bug? It builds fine locally. Discord suggests CI still has issues. |
bdf7c9f
to
700b4b7
Compare
Yeah, there is some misconfiguration here, as it shouldn't be attempting to compile "keymaps", as if it was a keymap folder. |
That does not seem something I can fix, if the QMK CI is reporting issues that do not exist. |
The problem is this part of the CI code: The CI code mistakenly parses the |
Thanks! I can remove the .py so the config issue isn't triggered. |
- Add configurator link in 46 readme.
d9d8ddb
to
12a7b17
Compare
Co-authored-by: mmccoyd <mmccoyd@cs.berkley.edu>
Co-authored-by: mmccoyd <mmccoyd@cs.berkley.edu>
Co-authored-by: mmccoyd <mmccoyd@cs.berkley.edu>
Description
Move Hillside keyboard family out of handwired as suggested by keyboard-magpie.
Context: Hillside started in handwired, despite being PCB based, based on an old organization standard for non-commercial boards.
The keymaps included by user manna-harbour_miryoku break because they still include RESET.Types of Changes
Issues Fixed or Closed by This PR
Checklist