Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kbdpadmk3 #18795

Merged
merged 19 commits into from
Dec 4, 2022
Merged

add kbdpadmk3 #18795

merged 19 commits into from
Dec 4, 2022

Conversation

moyi4681
Copy link
Contributor

@moyi4681 moyi4681 commented Oct 21, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 21, 2022
fauxpark
fauxpark requested changes Oct 21, 2022
View reviewed changes
keyboards/kbdfans/kbdpad/mk3/mk3.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 21, 2022 04:14
moyi4681 and others added 3 commits October 21, 2022 12:14
@drashna drashna requested a review from a team October 21, 2022 05:07
zvecr
zvecr requested changes Oct 21, 2022
View reviewed changes
keyboards/kbdfans/kbdpad/mk3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/kbdfans/kbdpad/mk3/mk3.h Outdated Show resolved Hide resolved
keyboards/kbdfans/kbdpad/mk3/info.json Outdated Show resolved Hide resolved
keyboards/kbdfans/kbdpad/mk3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna self-requested a review October 22, 2022 18:21
moyi4681 and others added 4 commits October 23, 2022 11:20
@moyi4681 @zvecr
Update keyboards/kbdfans/kbdpad/mk3/keymaps/default/keymap.c
9b53b89 
Co-authored-by: Joel Challis <git@zvecr.com>
@moyi4681 @zvecr
Update keyboards/kbdfans/kbdpad/mk3/mk3.h
208427e 
Co-authored-by: Joel Challis <git@zvecr.com>
@moyi4681 @zvecr
Update keyboards/kbdfans/kbdpad/mk3/info.json
45a968c 
Co-authored-by: Joel Challis <git@zvecr.com>
@moyi4681 @zvecr
Update keyboards/kbdfans/kbdpad/mk3/keymaps/via/keymap.c
5815712 
Co-authored-by: Joel Challis <git@zvecr.com>
fauxpark
fauxpark requested changes Oct 23, 2022
View reviewed changes
keyboards/kbdfans/kbdpad/mk3/mk3.h Outdated Show resolved Hide resolved
keyboards/kbdfans/kbdpad/mk3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kbdfans/kbdpad/mk3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
drashna
drashna previously approved these changes Oct 25, 2022
View reviewed changes
@drashna drashna self-requested a review October 25, 2022 05:49
@drashna drashna dismissed their stale review October 25, 2022 05:49

pending changes

moyi4681 and others added 3 commits October 25, 2022 15:59
@moyi4681 @fauxpark
Update keyboards/kbdfans/kbdpad/mk3/mk3.h
8a9704c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@moyi4681 @fauxpark
Update keyboards/kbdfans/kbdpad/mk3/keymaps/via/keymap.c
bc0cc7b 
Co-authored-by: Ryan <fauxpark@gmail.com>
@moyi4681 @fauxpark
Update keyboards/kbdfans/kbdpad/mk3/keymaps/default/keymap.c
aaaf075 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna requested a review from a team October 27, 2022 00:17
@moyi4681 moyi4681 mentioned this pull request Nov 1, 2022
Merged
6 tasks
@waffle87 waffle87 mentioned this pull request Nov 10, 2022
Closed
4 tasks
moyi4681 and others added 4 commits November 28, 2022 14:18
@moyi4681 @drashna
Update keyboards/kbdfans/kbdpad/mk3/mk3.c
8e626f8 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@moyi4681 @drashna
Update keyboards/kbdfans/kbdpad/mk3/mk3.c
ead758d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@moyi4681
update
1cc48ef
@moyi4681
Update keymap.c
7d16c1f
@moyi4681 moyi4681 requested review from drashna, fauxpark and zvecr and removed request for drashna, fauxpark and zvecr December 1, 2022 00:32
@moyi4681 moyi4681 requested review from zvecr and removed request for drashna December 2, 2022 03:41
@moyi4681 @drashna
Update keyboards/kbdfans/kbdpad/mk3/config.h
4d26547 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna merged commit 4d1b1bc into qmk:master Dec 4, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@moyi4681 @fauxpark
@zvecr @drashna @elpekenin
[Keyboard] add kbdpadmk3 (qmk#18795)
721a0d0 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@moyi4681 moyi4681 deleted the padmk3 branch December 10, 2022 09:59
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@moyi4681 @fauxpark
@zvecr @drashna @crembz
[Keyboard] add kbdpadmk3 (qmk#18795)
4e9ab6d 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@moyi4681 @fauxpark
@zvecr @drashna
[Keyboard] add kbdpadmk3 (qmk#18795)
6025753 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@moyi4681 @fauxpark
@zvecr @drashna @ideas32
[Keyboard] add kbdpadmk3 (qmk#18795)
21eaba2 
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moyi4681 @drashna @fauxpark @zvecr