Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more UNUSED_PINS defines #18940

Merged
merged 1 commit into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion keyboards/adpenrose/shisaku/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
*/
#define MATRIX_ROW_PINS { B2, B0, B1, D0, B4, D6, B3, D7 }
#define MATRIX_COL_PINS { D1, C3, C4, D4, C0, C1, C2 }
//#define UNUSED_PINS

/* COL2ROW, ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/cannonkeys/nearfield/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
/* key matrix pins */
#define MATRIX_ROW_PINS { B4, D2, D4, D6, D7 }
#define MATRIX_COL_PINS { D3, D5, C6, C7, B6, B5, B7, F0, F1, F4, F5, F6, F7, B3, B2, D1 }
#define UNUSED_PINS { E2, E6, D0, B1, B0 }

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/dumbpad/v1x_oled/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#define MATRIX_ROW_PINS { F4, F5, F6, F7 }
#define MATRIX_COL_PINS { C6, B1, B3, B2, B6 }
#define UNUSED_PINS

/* Dual rotary encoders */
#define ENCODERS_PAD_A { B4, E6 }
Expand Down
4 changes: 0 additions & 4 deletions keyboards/ferris/0_1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
{ B3, B2, B1, F0 }
#define MATRIX_COL_PINS_MCU \
{ D6, D7, B4, B5, B6 }
#define UNUSED_PINS_MCU \
{ B0, B7, C6, C7, D2, D3, D4, D5, E6, F1, F4, F5, F6, F7 }
#define MATRIX_ROW_PINS_MCP \
{ B0, B1, B2, B3 }
#define MATRIX_COL_PINS_MCP \
{ A0, A1, A2, A3, A4 }
#define UNUSED_PINS_MCP \
{ B4, B5, B6, B7, A5, A6, A7 }

/* COL2ROW, ROW2COL*/
#define DIODE_DIRECTION COL2ROW
Expand Down
4 changes: 0 additions & 4 deletions keyboards/ferris/0_2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,10 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
{ B7, B6, B5, A2 }
#define MATRIX_COL_PINS_MCU \
{ B8, B4, B3, A15, A14 }
#define UNUSED_PINS_MCU \
{ A0, A1, A3, A4, A5, A6, A7, A8, A9, A10, A13, B0, B1, B2, B9, B12, B13, B14, B15, C13, C14, C15, F0, F1 }
#define MATRIX_ROW_PINS_MCP \
{ B0, B1, B2, B3 }
#define MATRIX_COL_PINS_MCP \
{ A0, A1, A2, A3, A4 }
#define UNUSED_PINS_MCP \
{ B4, B5, B6, B7, A5, A6, A7 }

#define MATRIX_ROW_PINS \
{ B7, B6, B5, A2, A0, A0, A0, A0 }
Expand Down
1 change: 0 additions & 1 deletion keyboards/fjlabs/avalon/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// Checked with Eagle Schematic
#define MATRIX_ROW_PINS { F4, F1, F7, F6, F5 }
#define MATRIX_COL_PINS { B0, F0, B1, B2, B3, B7, D0, D1, D2, D3, D5, D7, B4, B5, B6, C6 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/fjlabs/peaker/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// Checked with Eagle Schematic
#define MATRIX_ROW_PINS { B5, B6, C0, E1, E0 }
#define MATRIX_COL_PINS { F2, F3, F4, F5, F6, F7, A0, A1, A2, A3, A4, A5, A6, A7, D5, D6, D7 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/fjlabs/sinanjuwk/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// Checked with Eagle Schematic
#define MATRIX_ROW_PINS { F4, F1, F7, F6, F5 }
#define MATRIX_COL_PINS { F0, B1, B2, B3, B7, D0, D1, D2, D3, D5, D7, B4, B5, B6 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
4 changes: 0 additions & 4 deletions keyboards/ingrained/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,10 @@
{ B0, B1, B2, B3 }
#define MATRIX_COL_PINS_MCU \
{ F7, F6, F5, F4, F1, F0 }
#define UNUSED_PINS_MCU \
{ B4, B5, B6, B7, C6, C7, D2, D3, D4, D5, D6, D7, E6}
#define MATRIX_ROW_PINS_MCP \
{ B0, B1, B2, B3 }
#define MATRIX_COL_PINS_MCP \
{ A0, A1, A2, A3, A4, A5 }
#define UNUSED_PINS_MCP \
{ B4, B5, B6, B7, A6, A7 }

/*
* Keyboard Matrix Assignments
Expand Down
1 change: 0 additions & 1 deletion keyboards/jkeys_design/gentleman65_se_s/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
/* key matrix pins */
#define MATRIX_ROW_PINS { F0, F1, F4, F5, F6 }
#define MATRIX_COL_PINS { D5, D3, D2, D1, D0, B7, B2, B3, D4, D6, D7, C7, C6, B6, B5, B4 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/kegen/gboy/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
/* key matrix pins */
#define MATRIX_ROW_PINS { F1, F4, F5, F6, F7 }
#define MATRIX_COL_PINS { E2, E6, C6, C7, D7, B6, B5, B4, B3, B2, B1, B0, D4, D6, D5, F0 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/keygem/kg60ansi/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// Checked with Eagle Schematic
#define MATRIX_ROW_PINS { F0, F1, F4, F5, F6 }
#define MATRIX_COL_PINS { C7, C6, B6, B5, B4, D7, D6, D4, D5, D3, D2, B3, B2, B1 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/keygem/kg65rgbv2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// Checked with Eagle Schematic
#define MATRIX_ROW_PINS { F0, F1, F4, F5, F6 }
#define MATRIX_COL_PINS { C7, C6, B6, B5, B4, D7, D6, D4, D5, D3, D2, B3, B2, B1, D1 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/keyten/aperture/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
/* key matrix pins */
#define MATRIX_ROW_PINS { D1, D0, F7, F5, F6 }
#define MATRIX_COL_PINS { B7, F0, F1, F4, C7, C6, B6, B5, B4, D7, D6, D4, D5, D3, D2 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/kopibeng/mnk65/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

#define MATRIX_ROW_PINS { B3, D0, F6, F4, F1 }
#define MATRIX_COL_PINS { B7, F7, C7, C6, B6, B5, B4, D7, D6, D4, D5, D3, D2, D1, F5 }
#define UNUSED_PINS

#define LED_CAPS_LOCK_PIN F0

Expand Down
1 change: 0 additions & 1 deletion keyboards/linworks/fave104/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#define MATRIX_ROW_PINS { B11, B10, B2, B1, B0, A7, A6, A5, A4, A3, A2, A0 }
#define MATRIX_COL_PINS { B12, B13, B14, B15, A8, A9, A10, A13, A14, A15, B3 }
#define UNUSED_PINS

#define LED_NUM_LOCK_PIN B6
#define LED_CAPS_LOCK_PIN B5
Expand Down
1 change: 0 additions & 1 deletion keyboards/mechlovin/foundation/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#define MATRIX_ROW_PINS { B12, B13, B14, A8, A2 }
#define MATRIX_COL_PINS { B11, B10, B2, B1, B0, A7, A6, A5, A4, A3, A15, B9, B8, B7, B6, B5, B4, B3}
#define UNUSED_PINS

/* key matrix size */
#define MATRIX_ROWS 5
Expand Down
1 change: 0 additions & 1 deletion keyboards/mechwild/puckbuddy/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
*/
#define MATRIX_ROW_PINS { B12, B13, B14, B15 }
#define MATRIX_COL_PINS { B10, A8, B4, B5 }
#define UNUSED_PINS

/* spi config */
#define SPI_DRIVER SPID1
Expand Down
1 change: 0 additions & 1 deletion keyboards/mokey/ibis80/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#define MATRIX_ROW_PINS { B0, B1, B2, E6, F0, F1 }
#define MATRIX_COL_PINS { D0, D1, D2, D3, D5, D4, D6, D7, B4, B5, B6, C6, C7, F7, F6, F5, F4 }
#define UNUSED_PINS

/* COL2ROW, ROW2COL*/
#define DIODE_DIRECTION COL2ROW
Expand Down
24 changes: 0 additions & 24 deletions keyboards/ploopyco/trackball_thumb/rev1_001/config.h

This file was deleted.

13 changes: 0 additions & 13 deletions keyboards/ploopyco/trackball_thumb/trackball_thumb.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,19 +188,6 @@ void keyboard_pre_init_kb(void) {
setPinInput(OPT_ENC1);
setPinInput(OPT_ENC2);

/* Ground all output pins connected to ground. This provides additional
* pathways to ground. If you're messing with this, know this: driving ANY
* of these pins high will cause a short. On the MCU. Ka-blooey.
*/
#ifdef UNUSED_PINS
const pin_t unused_pins[] = UNUSED_PINS;

for (uint8_t i = 0; i < (sizeof(unused_pins) / sizeof(pin_t)); i++) {
setPinOutput(unused_pins[i]);
writePinLow(unused_pins[i]);
}
#endif

// This is the debug LED.
#if defined(DEBUG_LED_PIN)
setPinOutput(DEBUG_LED_PIN);
Expand Down
1 change: 0 additions & 1 deletion keyboards/plywrks/lune/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#define MATRIX_ROW_PINS { F1, F0, B7, B0, B6, B5, D7, B4, D6 }
#define MATRIX_COL_PINS { F4, F5, F6, F7, D4, D5, D3, D2 }
#define UNUSED_PINS

/* COL2ROW, ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/xelus/valor_frl_tkl/rev2_0/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
/* key matrix pins */
#define MATRIX_ROW_PINS { A15, A14, A10, B3, B4 }
#define MATRIX_COL_PINS { A9, A8, B15, B14, B13, B12, B9, B1, B0, A7, A6, A5, A4, A3, A2, A1, A0 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down
1 change: 0 additions & 1 deletion keyboards/xelus/valor_frl_tkl/rev2_1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
/* key matrix pins */
#define MATRIX_ROW_PINS { A15, A14, A13, B3, B4 }
#define MATRIX_COL_PINS { A10, A8, B15, B14, B13, B12, B9, B1, B0, A7, A6, A5, A4, A3, A2, A1, A0 }
#define UNUSED_PINS

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW
Expand Down