Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked backlight keycodes. #18961

Merged
merged 7 commits into from
Nov 5, 2022
Merged

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Nov 5, 2022

Description

As per the title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from fauxpark and a team November 5, 2022 12:49
@tzarc tzarc force-pushed the backlight_keycode_refactor branch from 4ad9e36 to 070b8aa Compare November 5, 2022 13:01
data/constants/keycodes/keycodes_0.0.1_lighting.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_lighting.hjson Outdated Show resolved Hide resolved
docs/feature_backlight.md Outdated Show resolved Hide resolved
docs/feature_led_matrix.md Outdated Show resolved Hide resolved
docs/keycodes.md Outdated Show resolved Hide resolved
quantum/process_keycode/process_backlight.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_backlight.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_backlight.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_backlight.c Outdated Show resolved Hide resolved
quantum/quantum_keycodes_legacy.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added keyboard keymap python via Adds via keymap and/or updates keyboard for via support labels Nov 5, 2022
tzarc and others added 2 commits November 6, 2022 00:19
Co-authored-by: Ryan <fauxpark@gmail.com>
@tzarc tzarc merged commit 219afab into qmk:develop Nov 5, 2022
@tzarc tzarc deleted the backlight_keycode_refactor branch November 5, 2022 21:12
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants