Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prototype for get_hold_on_other_key_press to resolve #18855 #19056

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Add missing prototype for get_hold_on_other_key_press to resolve #18855 #19056

merged 1 commit into from
Nov 13, 2022

Conversation

nicknimchuk
Copy link
Contributor

Description

Adds the missing function prototype for get_hold_on_other_key_press in /quantum/action_tapping.h. The missing prototype doesn't cause errors most of the time, but does (at least) if both auto-shift and HOLD_ON_OTHER_KEY_PRESS_PER_KEY are enabled, due to use of get_hold_on_other_key_press in quantum/process_keycode/process_auto_shift.c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 13, 2022
@zvecr zvecr added the bug label Nov 13, 2022
@zvecr zvecr requested a review from a team November 13, 2022 15:44
@tzarc tzarc merged commit c1ef943 into qmk:develop Nov 13, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants