Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to mouse_report_t (which doesnt exist) #19107

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

elpekenin
Copy link
Contributor

Description

Noticed some references to an unexisting type on the docs and replaced them by the actual one. It should also fix a (probably unreachable) branch of the ploopy's code

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failures look unrelated to the change. The drag_scroll keymap for ploopyco/trackball_mini/rev1_001 and ploopyco/trackball_mini/rev1_002 was already broken before — apparently #13043 added DRAG_SCROLL at the keyboard level, so the keymap level implementation should probably be dropped now, but that would be another PR.

@sigprof sigprof requested a review from a team November 18, 2022 15:06
@zvecr zvecr merged commit fe652e6 into qmk:develop Nov 18, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@elpekenin elpekenin deleted the pointing-typo branch November 30, 2022 17:53
elpekenin added a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants