Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish constants metadata to API #19143

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Publish constants metadata to API #19143

merged 2 commits into from
Nov 23, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 23, 2022 •
edited
Loading

Description

  • generic search to try and cover future additions
  • somewhat aligned to existing metadata files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team November 23, 2022 17:57
@github-actions github-actions bot added cli qmk cli command python labels Nov 23, 2022
@zvecr zvecr merged commit dfa5390 into qmk:develop Nov 23, 2022
@zvecr zvecr deleted the feature/spec_metadata branch November 23, 2022 19:34
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Publish constants metadata to API (qmk#19143)
d5f8d67 
* Publish metadata

* Ensure content is sorted
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Publish constants metadata to API (qmk#19143)
457aaf1 
* Publish metadata

* Ensure content is sorted
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@zvecr @crembz
Publish constants metadata to API (qmk#19143)
3a72ef9 
* Publish metadata

* Ensure content is sorted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc