Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RGBLIGHT_ANIMATIONS from core (+cleanup) #19216

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Remove RGBLIGHT_ANIMATIONS from core (+cleanup) #19216

merged 1 commit into from
Dec 1, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 30, 2022

Description

Removes the RGBLIGHT_ANIMATIONS support from core, officially.

And cleans up some missed/added later configs.

Types of Changes

  • Core
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team November 30, 2022 21:41
SethBarberee
SethBarberee approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@SethBarberee SethBarberee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from me on the updates to my userspace.

@drashna drashna merged commit 50661ab into qmk:develop Dec 1, 2022
@drashna drashna deleted the rgblight/nuke_animations branch December 1, 2022 21:06
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@drashna @elpekenin
Remove RGBLIGHT_ANIMATIONS from core (+cleanup) (qmk#19216)
b9b35e6
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@drashna @omikronik
Remove RGBLIGHT_ANIMATIONS from core (+cleanup) (qmk#19216)
192bd6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethBarberee SethBarberee SethBarberee approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @tzarc @fauxpark @SethBarberee