Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig file #1930

Merged
merged 4 commits into from
Oct 31, 2017
Merged

Add EditorConfig file #1930

merged 4 commits into from
Oct 31, 2017

Conversation

dudeofawesome
Copy link
Contributor

This makes supported editors automatically change their settings to match desired coding conventions.

I also added a file to cause VS Code to prompt the user to install the EditorConfig extension when they open the project. If this is felt to be too opinionated, I can revert it.

This makes supported editors automatically change their settings to match desired code styles
This will cause VS Code to prompt the user to install the EditorConfig extension when they open the project.

If this is felt to be too opinionated, I can revert it.
@jackhumbert
Copy link
Member

Nice! Thanks :)

@jackhumbert jackhumbert merged commit 6169cd5 into qmk:master Oct 31, 2017
kgwong pushed a commit to kgwong/qmk_firmware that referenced this pull request Nov 26, 2017
* 🔧 add editorconfig

This makes supported editors automatically change their settings to match desired code styles

* 🔧 add extension recommendation for VSCode

This will cause VS Code to prompt the user to install the EditorConfig extension when they open the project.

If this is felt to be too opinionated, I can revert it.
LovesTha pushed a commit to LovesTha/qmk_firmware that referenced this pull request Jul 24, 2018
* 🔧 add editorconfig

This makes supported editors automatically change their settings to match desired code styles

* 🔧 add extension recommendation for VSCode

This will cause VS Code to prompt the user to install the EditorConfig extension when they open the project.

If this is felt to be too opinionated, I can revert it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants