Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XAP style merge semantics for DD keycodes #19397

Merged
merged 3 commits into from
Jan 1, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 22, 2022

Description

keycodes_0.0.2_quantum.hjson could contain the following to ignore any existing keycodes

{
    "keycodes": {
        "!reset!":0,

        "0x7C00": {
            "group": "quantum",
            "key": "QK_BOOTLOADER",
            "aliases": [
                "QK_BOOT"
            ]
        },
    }
}

Likewise keycodes_0.0.2.hjson could contain the following to ignore any existing ranges

{
    "ranges": {
        "!reset!":0,

        "0x0000/0x00FF": {
            "define": "QK_BASIC"
        },
    }
}

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Dec 22, 2022
@zvecr zvecr changed the title Implement XAP style merge semantics Implement XAP style merge semantics for DD keycodes Dec 22, 2022
@zvecr zvecr requested a review from a team December 22, 2022 14:16
@zvecr zvecr marked this pull request as ready for review December 22, 2022 14:16
@zvecr zvecr merged commit 24adecd into qmk:develop Jan 1, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants