Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kt3700 PCB #19432

Merged
merged 31 commits into from
Jan 17, 2023
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
06c22c8
Create readme.md
key10iq Dec 27, 2022
8798a5b
Add files via upload
key10iq Dec 27, 2022
5883ba3
Create readme.md
key10iq Dec 27, 2022
c332d3b
Add files via upload
key10iq Dec 27, 2022
d295d8e
Create readme.md
key10iq Dec 27, 2022
196378c
Add files via upload
key10iq Dec 27, 2022
1962c4e
Update keyboards/keyten/kt3700/keymaps/default/keymap.c
key10iq Dec 28, 2022
4dc2e32
Update keyboards/keyten/kt3700/kt3700.c
key10iq Dec 28, 2022
d973df9
Update keyboards/keyten/kt3700/keymaps/via/keymap.c
key10iq Dec 28, 2022
05c6157
Update keyboards/keyten/kt3700/kt3700.h
key10iq Dec 28, 2022
f084d2e
Update keyboards/keyten/kt3700/readme.md
key10iq Dec 28, 2022
b5a8239
Update keyboards/keyten/kt3700/rules.mk
key10iq Dec 28, 2022
4e36f3c
Update kt3700.c
key10iq Dec 28, 2022
852b005
Update keymap.c
key10iq Dec 28, 2022
852a2a6
Update info.json
key10iq Dec 28, 2022
61e2f5f
Update kt3700.h
key10iq Dec 28, 2022
4df3252
Update keymap.c
key10iq Dec 28, 2022
26a4306
Update keymap.c
key10iq Dec 28, 2022
a4143f0
Update keyboards/keyten/kt3700/readme.md
key10iq Dec 28, 2022
40bd5bd
Update keyboards/keyten/kt3700/rules.mk
key10iq Dec 28, 2022
c705ee0
Update kt3700.h
key10iq Dec 28, 2022
ee103a2
Update info.json
key10iq Dec 28, 2022
a800c52
Update keymap.c
key10iq Dec 28, 2022
9698a7e
Update keymap.c
key10iq Dec 28, 2022
225e2fb
Update keyboards/keyten/kt3700/keymaps/default/keymap.c
key10iq Dec 28, 2022
4bae272
Update keyboards/keyten/kt3700/rules.mk
key10iq Jan 4, 2023
dc116b5
Update keyboards/keyten/kt3700/info.json
key10iq Jan 14, 2023
4267b73
Update info.json
key10iq Jan 14, 2023
d16432e
Update keyboards/keyten/kt3700/config.h
key10iq Jan 15, 2023
7c4a4e6
Update keyboards/keyten/kt3700/rules.mk
key10iq Jan 15, 2023
ef48f50
Update keyboards/keyten/kt3700/info.json
key10iq Jan 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions keyboards/keyten/kt3700/config.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/*
Copyright 2022 Ivan Gromov (@key10iq)

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#pragma once

#include "config_common.h"

/* key matrix size */
#define MATRIX_ROWS 6
#define MATRIX_COLS 4

key10iq marked this conversation as resolved.
Show resolved Hide resolved
/*
* Keyboard Matrix Assignments
*
* Change this to how you wired your keyboard
* COLS: AVR pins used for columns, left to right
* ROWS: AVR pins used for rows, top to bottom
* DIODE_DIRECTION: COL2ROW = COL = Anode (+), ROW = Cathode (-, marked on diode)
* ROW2COL = ROW = Anode (+), COL = Cathode (-, marked on diode)
*
*/
#define MATRIX_ROW_PINS { B12, B7, B5, B4, B3, A15 }
#define MATRIX_COL_PINS { B0, B13, B9, B8 }

/* COL2ROW or ROW2COL */
#define DIODE_DIRECTION COL2ROW

#define LED_NUM_LOCK_PIN B6

/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5
109 changes: 109 additions & 0 deletions keyboards/keyten/kt3700/info.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
{
"keyboard_name": "kt3700",
"manufacturer": "keyten",
"url": "",
"maintainer": "key10iq",
"usb": {
"vid": "0xEB69",
"pid": "0x3700",
"device_version": "0.0.1"
},
key10iq marked this conversation as resolved.
Show resolved Hide resolved
"community_layouts": ["numpad_6x4", "ortho_6x4"],
"layouts": {
"LAYOUT_all": {
"layout": [
{"x":0, "y":0},
{"x":1, "y":0},
{"x":2, "y":0},
{"x":3, "y":0},

{"x":0, "y":2},
{"x":1, "y":2},
{"x":2, "y":2},
{"x":3, "y":2},

{"x":0, "y":3},
{"x":1, "y":3},
{"x":2, "y":3},
{"x":3, "y":3},

{"x":0, "y":4},
{"x":1, "y":4},
{"x":2, "y":4},
{"x":3, "y":4},

{"x":0, "y":5},
{"x":1, "y":5},
{"x":2, "y":5},
{"x":3, "y":5},

{"x":0, "y":6},
{"x":1, "y":6},
{"x":2, "y":6},
{"x":3, "y":6}
]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"LAYOUT_all": {
"layout": [
{"x":0, "y":0},
{"x":1, "y":0},
{"x":2, "y":0},
{"x":3, "y":0},
{"x":0, "y":2},
{"x":1, "y":2},
{"x":2, "y":2},
{"x":3, "y":2},
{"x":0, "y":3},
{"x":1, "y":3},
{"x":2, "y":3},
{"x":3, "y":3},
{"x":0, "y":4},
{"x":1, "y":4},
{"x":2, "y":4},
{"x":3, "y":4},
{"x":0, "y":5},
{"x":1, "y":5},
{"x":2, "y":5},
{"x":3, "y":5},
{"x":0, "y":6},
{"x":1, "y":6},
{"x":2, "y":6},
{"x":3, "y":6}
]
},

"LAYOUT_numpad_6x4": {
"layout": [
{"x":0, "y":0},
{"x":1, "y":0},
{"x":2, "y":0},
{"x":3, "y":0},

{"x":0, "y":2},
{"x":1, "y":2},
{"x":2, "y":2},
{"x":3, "y":2},

{"x":0, "y":3},
{"x":1, "y":3},
{"x":2, "y":3},
{"x":3, "y":3, "h":2},

{"x":0, "y":4},
{"x":1, "y":4},
{"x":2, "y":4},
{"x":0, "y":5},
{"x":1, "y":5},
{"x":2, "y":5},
{"x":3, "y":5, "h":2},

{"x":0, "y":6, "w":2},
{"x":2, "y":6}
key10iq marked this conversation as resolved.
Show resolved Hide resolved
]
},
"LAYOUT_ortho_6x4": {
"layout": [
{"x":0, "y":0},
{"x":1, "y":0},
{"x":2, "y":0},
{"x":3, "y":0},

{"x":0, "y":2},
{"x":1, "y":2},
{"x":2, "y":2},
{"x":3, "y":2},

{"x":0, "y":3},
{"x":1, "y":3},
{"x":2, "y":3},
{"x":3, "y":3},

{"x":0, "y":4},
{"x":1, "y":4},
{"x":2, "y":4},
{"x":3, "y":4},

{"x":0, "y":5},
{"x":1, "y":5},
{"x":2, "y":5},
{"x":3, "y":5},

{"x":0, "y":6},
{"x":1, "y":6},
{"x":2, "y":6},
{"x":3, "y":6}
]
}
}
}
36 changes: 36 additions & 0 deletions keyboards/keyten/kt3700/keymaps/default/keymap.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/* Copyright 2022 Ivan Gromov (@key10iq)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include QMK_KEYBOARD_H

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

[0] = LAYOUT_all(
KC_ESC, KC_LCTL, KC_LALT, KC_BSPC,
KC_NUM, KC_PSLS, KC_PAST, KC_PMNS,
KC_P7, KC_P8, KC_P9, KC_PSCR,
KC_P4, KC_P5, KC_P6, KC_PPLS,
KC_P1, KC_P2, KC_P3, KC_DEL,
KC_INS, KC_P0, KC_PDOT, KC_PENT),

[1] = LAYOUT_all(
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[0] = LAYOUT_all(
KC_ESC, KC_LCTL, KC_LALT, KC_BSPC,
KC_NUM, KC_PSLS, KC_PAST, KC_PMNS,
KC_P7, KC_P8, KC_P9, KC_PSCR,
KC_P4, KC_P5, KC_P6, KC_PPLS,
KC_P1, KC_P2, KC_P3, KC_DEL,
KC_INS, KC_P0, KC_PDOT, KC_PENT),
[1] = LAYOUT_all(
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______)
[0] = LAYOUT_ortho_6x4(
KC_ESC, KC_LCTL, KC_LALT, KC_BSPC,
KC_NUM, KC_PSLS, KC_PAST, KC_PMNS,
KC_P7, KC_P8, KC_P9, KC_PSCR,
KC_P4, KC_P5, KC_P6, KC_PPLS,
KC_P1, KC_P2, KC_P3, KC_DEL,
KC_INS, KC_P0, KC_PDOT, KC_PENT)

};
1 change: 1 addition & 0 deletions keyboards/keyten/kt3700/keymaps/default/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# The default keymap for kt3700
52 changes: 52 additions & 0 deletions keyboards/keyten/kt3700/keymaps/via/keymap.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/* Copyright 2022 Ivan Gromov (@key10iq)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include QMK_KEYBOARD_H

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

[0] = LAYOUT_all(
KC_ESC, KC_LCTL, KC_LALT, KC_BSPC,
KC_NUM, KC_PSLS, KC_PAST, KC_PMNS,
KC_P7, KC_P8, KC_P9, KC_PSCR,
KC_P4, KC_P5, KC_P6, KC_PPLS,
KC_P1, KC_P2, KC_P3, KC_DEL,
KC_INS, KC_P0, KC_PDOT, KC_PENT),

[1] = LAYOUT_all(
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______),

[2] = LAYOUT_all(
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______),

[3] = LAYOUT_all(
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______,
_______, _______, _______, _______)
};
1 change: 1 addition & 0 deletions keyboards/keyten/kt3700/keymaps/via/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# The VIA keymap for kt3700
1 change: 1 addition & 0 deletions keyboards/keyten/kt3700/keymaps/via/rules.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
VIA_ENABLE = yes
17 changes: 17 additions & 0 deletions keyboards/keyten/kt3700/kt3700.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* Copyright 2022 Ivan Gromov (@key10iq)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "kt3700.h"
120 changes: 120 additions & 0 deletions keyboards/keyten/kt3700/kt3700.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
/* Copyright 2022 Ivan Gromov (@key10iq)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#pragma once

#include "quantum.h"

#define XXX KC_NO

/* LAYOUT_all
* ┌───┬───┬───┬───┐
* │00 │01 │02 │03 │
* ├───┴───┴───┴───┤
* │ │
* ├───┬───┬───┬───┤
* │10 │11 │12 │13 │
* ├───┼───┼───┼───┤
* │20 │21 │22 │23 │
* ├───┼───┼───┼───┤
* │30 │31 │32 │33 │
* ├───┼───┼───┼───┤
* │40 │41 │42 │43 │
* ├───┼───┼───┼───┤
* │50 │51 │52 │53 │
* └───┴───┴───┴───┘
*/
#define LAYOUT_all( \
K00, K01, K02, K03, \
K10, K11, K12, K13, \
K20, K21, K22, K23, \
K30, K31, K32, K33, \
K40, K41, K42, K43, \
K50, K51, K52, K53 \
) { \
{ K00, K01, K02, K03 }, \
{ K10, K11, K12, K13 }, \
{ K20, K21, K22, K23 }, \
{ K30, K31, K32, K33 }, \
{ K40, K41, K42, K43 }, \
{ K50, K51, K52, K53 } \
}
Copy link
Member

@zvecr zvecr Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt add any value, at a push it should instead be just #define LAYOUT_all LAYOUT_ortho_6x4 or the info.json equivalent :

    "layout_aliases": {
        "LAYOUT_all": "LAYOUT_ortho_6x4"
    },
Suggested change
/* LAYOUT_all
* ┌───┬───┬───┬───┐
*00010203
* ├───┴───┴───┴───┤
* │ │
* ├───┬───┬───┬───┤
*10111213
* ├───┼───┼───┼───┤
*20212223
* ├───┼───┼───┼───┤
*30313233
* ├───┼───┼───┼───┤
*40414243
* ├───┼───┼───┼───┤
*50515253
* └───┴───┴───┴───┘
*/
#define LAYOUT_all( \
K00, K01, K02, K03, \
K10, K11, K12, K13, \
K20, K21, K22, K23, \
K30, K31, K32, K33, \
K40, K41, K42, K43, \
K50, K51, K52, K53 \
) { \
{ K00, K01, K02, K03 }, \
{ K10, K11, K12, K13 }, \
{ K20, K21, K22, K23 }, \
{ K30, K31, K32, K33 }, \
{ K40, K41, K42, K43 }, \
{ K50, K51, K52, K53 } \
}


/* LAYOUT_numpad_6x4
* ┌───┬───┬───┬───┐
* │00 │01 │02 │03 │
* ├───┴───┴───┴───┤
* │ │
* ├───┬───┬───┬───┤
* │10 │11 │12 │13 │
* ├───┼───┼───┼───┤
* │20 │21 │22 │ │
* ├───┼───┼───┤33 │
* │30 │31 │32 │ │
* ├───┼───┼───┼───┤
* │40 │41 │42 │ │
* ├───┴───┼───┤53 │
* │ 51 │52 │ │
* └───────┴───┴───┘
*/
#define LAYOUT_numpad_6x4( \
Copy link
Member

@zvecr zvecr Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isnt numpad_6x4 when it comes to community layouts, all references should be updated to just LAYOUT (or maybe LAYOUT_ortho_6x4)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PCB photo shows that the common numpad_6x4 layout is supported too, therefore both LAYOUT_numpad_6x4 and LAYOUT_all layout macros should be defined (and also the LAYOUT_ortho_6x4 alias for LAYOUT_all).

Alternatively, the layout matrix data could be added to info.json instead of defining the macros in C.

K00, K01, K02, K03, \
K10, K11, K12, K13, \
K20, K21, K22, \
K30, K31, K32, K33, \
K40, K41, K42, \
K51, K52, K53 \
) { \
{ K00, K01, K02, K03 }, \
{ K10, K11, K12, K13 }, \
{ K20, K21, K22, XXX }, \
{ K30, K31, K32, K33 }, \
{ K40, K41, K42, XXX }, \
{ XXX, K51, K52, K53 } \
}

/* LAYOUT_ortho_6x4
* ┌───┬───┬───┬───┐
* │00 │01 │02 │03 │
* ├───┴───┴───┴───┤
* │ │
* ├───┬───┬───┬───┤
* │10 │11 │12 │13 │
* ├───┼───┼───┼───┤
* │20 │21 │22 │23 │
* ├───┼───┼───┼───┤
* │30 │31 │32 │33 │
* ├───┼───┼───┼───┤
* │40 │41 │42 │43 │
* ├───┼───┼───┼───┤
* │50 │51 │52 │53 │
* └───┴───┴───┴───┘
*/
#define LAYOUT_ortho_6x4( \
K00, K01, K02, K03, \
K10, K11, K12, K13, \
K20, K21, K22, K23, \
K30, K31, K32, K33, \
K40, K41, K42, K43, \
K50, K51, K52, K53 \
) { \
{ K00, K01, K02, K03 }, \
{ K10, K11, K12, K13 }, \
{ K20, K21, K22, K23 }, \
{ K30, K31, K32, K33 }, \
{ K40, K41, K42, K43 }, \
{ K50, K51, K52, K53 } \
}
Loading