Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate submodule dirty check to CLI #19488

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Migrate submodule dirty check to CLI #19488

merged 1 commit into from
Jan 6, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 3, 2023 •
edited
Loading

Description

Currently avoids using submodule.update as updating the code to work in existing cases and the submodule command is rather messy. Longer term, this will be resolved.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core python labels Jan 3, 2023
@zvecr zvecr marked this pull request as ready for review January 4, 2023 05:03
@zvecr zvecr requested a review from a team January 4, 2023 05:03
@zvecr zvecr force-pushed the feature/cli_submodule_check branch from 76d43cf to 79452ac Compare January 4, 2023 05:10
@fauxpark
Copy link
Member

fauxpark commented Jan 4, 2023

Could be worth adding a flag to nuke before syncing?

@zvecr
Copy link
Member Author

zvecr commented Jan 6, 2023

Could be worth adding a flag to nuke before syncing?

Will look into adding in the next PR!

@zvecr zvecr merged commit 5c730d9 into qmk:develop Jan 6, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Migrate submodule dirty check to CLI (qmk#19488)
75f9621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark