Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias support for converters #19563

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 11, 2023

Description

Longer term, #19533 will explore "better" and more complete solutions. For now this avoids things like symlinks, and is fairly trivial to unpick if/when we select a different solution.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 11, 2023
@zvecr zvecr force-pushed the feature/converter_aliases_alt branch from 5f972f8 to 1b981be Compare January 11, 2023 19:34
@zvecr zvecr requested a review from a team January 11, 2023 19:34
@keyboard-magpie keyboard-magpie merged commit 12f1a30 into qmk:develop Jan 18, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants