Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functions with empty params #19647

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Fix functions with empty params #19647

merged 2 commits into from
Jan 20, 2023

Conversation

fauxpark
Copy link
Member

Description

Per the C11 standard, §6.11.6:

The use of function declarators with empty parentheses (not prototype-format parameter type declarators) is an obsolescent feature.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 20, 2023 10:15
@zvecr zvecr merged commit cf935d9 into qmk:develop Jan 20, 2023
@fauxpark fauxpark deleted the fix-empty-function-params branch January 20, 2023 17:35
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request Jan 22, 2023
@freznel10
Squashed commit of the following:
ff5983b 
commit d04dbd9
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Sat Jan 21 23:46:39 2023 -0700

    cleanup and force max multiplier to simplify (multiplier can be adjusted at runtime)

commit 22170a6
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Sat Jan 21 18:52:18 2023 -0700

    fixing up arm code from rebase

commit e440046
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Jan 17 07:30:05 2023 -0700

    rebase and cleanup

commit c14127c
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Jan 17 07:18:10 2023 -0700

    finally fix hscroll fully and add maybe ability to change multiplier at runtime

commit ec686da
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Mon Jan 16 13:44:14 2023 -0700

    major update/revision most issues fixed

commit 591cedb
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Jan 10 22:54:48 2023 -0700

    bugfix for disable function

commit d6b4def
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Jan 10 21:32:56 2023 -0700

    Fix HID descriptor for Horizontal scroll, add disable function, and various bugfixes

commit badb248
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Sat Jan 7 22:55:18 2023 -0700

    linting except on vusb and doc update

commit 4fc1b53
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Sat Jan 7 21:49:47 2023 -0700

    all tested versions working and doc

commit af20361
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Fri Jan 6 11:53:00 2023 -0700

    real initial release everything working and tested on Atmel U4 chips

commit a6d5417
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Wed Jan 4 12:15:44 2023 -0700

    update: not broken... but not working either

commit 7a0769b
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Mon Jan 2 09:51:37 2023 -0700

    initial commit (currently broken...)

commit 49c5f6c
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Fri Dec 23 14:58:39 2022 -0700

    doc update

commit 5e9fc72
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Fri Dec 23 14:51:37 2022 -0700

    linting

commit 5a2741d
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Thu Dec 22 19:13:24 2022 -0700

    fixes and doc improvements

commit 8588277
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Wed Dec 21 23:07:52 2022 -0700

    fix previous changes to precision mode now working as intended additional mode fixes

commit ee24b83
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Wed Dec 21 20:29:11 2022 -0700

    doc update and precision changes

commit e6cb3be
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Dec 13 00:53:47 2022 -0700

    more doc updates/code cleanup

commit 82686e2
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Tue Dec 13 00:20:15 2022 -0700

    code and doc fixup

commit 25b3f43
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Mon Dec 12 23:10:19 2022 -0700

    update and linting

commit c6b548f
Author: Alabastard-64 <snipac+github@gmail.com>
Date:   Sun Dec 11 21:08:08 2022 -0700

    post rebase/squash cleanup

commit 0a98d21
Author: Alabastard-64 <96358682+Alabastard-64@users.noreply.github.com>
Date:   Tue Aug 30 01:23:41 2022 -0600

    parent c6ab70e
    author Alabastard-64 <96358682+Alabastard-64@users.noreply.github.com> 1661844221 -0600
    committer Alabastard-64 <snipac+github@gmail.com> 1670816485 -0700

    parent c6ab70e
    author Alabastard-64 <96358682+Alabastard-64@users.noreply.github.com> 1661844221 -0600
    committer Alabastard-64 <snipac+github@gmail.com> 1670813789 -0700

    parent c6ab70e
    author Alabastard-64 <96358682+Alabastard-64@users.noreply.github.com> 1661844221 -0600
    committer Alabastard-64 <snipac+github@gmail.com> 1670812067 -0700

    Squashed all previous Commits

commit 713003b
Merge: cf935d9 300a0de
Author: QMK Bot <hello@qmk.fm>
Date:   Fri Jan 20 19:43:58 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 300a0de
Author: era <73109780+eerraa@users.noreply.github.com>
Date:   Sat Jan 21 04:43:11 2023 +0900

    Change era65 keymap&debounce_type (qmk#19627)

commit cf935d9
Author: Ryan <fauxpark@gmail.com>
Date:   Sat Jan 21 03:21:17 2023 +1100

    Fix functions with empty params (qmk#19647)

    * Fix functions with empty params

    * Found a bunch more
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@fauxpark @omikronik
Fix functions with empty params (qmk#19647)
b5b3d42 
* Fix functions with empty params

* Found a bunch more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @zvecr