Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keymap introspection for combos. #19670

Merged
merged 4 commits into from
May 15, 2023
Merged

Keymap introspection for combos. #19670

merged 4 commits into from
May 15, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 23, 2023

Description

Adds introspection getters for combos.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team January 23, 2023 20:17
@github-actions github-actions bot added the core label Jan 23, 2023
@tzarc
Copy link
Member Author

tzarc commented Jan 23, 2023 •
edited
Loading

Docs changes pending.
Tests too, apparently.

@tzarc tzarc force-pushed the introspection-combo branch from a204aca to 6f037cd Compare March 2, 2023 23:10
@tzarc tzarc force-pushed the introspection-combo branch from 6f037cd to 0448218 Compare May 1, 2023 10:38
@tzarc
Copy link
Member Author

tzarc commented May 1, 2023

Tests are okay, now. Docs coming.

@tzarc tzarc marked this pull request as ready for review May 1, 2023 12:19
@drashna drashna requested a review from a team May 6, 2023 08:14
@tzarc tzarc force-pushed the introspection-combo branch from 52d8157 to f1fcd22 Compare May 14, 2023 03:45
@tzarc tzarc merged commit 5faa23d into qmk:develop May 15, 2023
@tzarc tzarc deleted the introspection-combo branch May 15, 2023 12:27
@drashna drashna mentioned this pull request May 20, 2023
Merged
14 tasks
@EdenEast EdenEast mentioned this pull request Jun 6, 2023
Closed
2 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@tzarc @coquizen
Keymap introspection for combos. (qmk#19670)
eb53c96
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@tzarc @autoferrit
Keymap introspection for combos. (qmk#19670)
4288ec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @drashna