Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Song List configuration for Audio feature #19724

Closed
wants to merge 1 commit into from

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 31, 2023

Description

See Title.

But speciflcally, the song list needs to be included in the config.h "stuff" or custom song values will not be respected.

#19714 breaks this, and #19722 further breaks this. I can confirm that this breaks ALL of these configs: https://docs.qmk.fm/#/feature_audio?id=audio-config

This was mentioned by me already: link

If there is a better solution that will respect the settings, I'm open for it, but right now, this is completely broken.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have actually tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from tzarc and zvecr January 31, 2023 00:15
@drashna drashna closed this Jan 31, 2023
@drashna drashna deleted the fix/song_list branch January 31, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant