Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support new revision for Paws60 #19943

Closed
wants to merge 2 commits into from
Closed

Added support new revision for Paws60 #19943

wants to merge 2 commits into from

Conversation

HorrorTroll
Copy link
Contributor

Description

Added support new revision for Paws60

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 26, 2023
drashna
drashna requested changes Feb 28, 2023
View reviewed changes
keyboards/horrortroll/paws60/rev2/lib/custom_keycode.h
@@ -14,4 +14,14 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#include "paws60.h"
enum custom_keycodes {
RED_ESC = SAFE_RANGE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RED_ESC = SAFE_RANGE,
RED_ESC = QK_KB,

keyboards/horrortroll/paws60/rev2/readme.md
@@ -0,0 +1,29 @@
# Paws60 (Rev 2)

![Paws60](https://i.imgur.com/eRviqJy.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Paws60](https://i.imgur.com/eRviqJy.png)
![Paws60](https://i.imgur.com/eRviqJyh.png)

@lesshonor lesshonor mentioned this pull request Mar 2, 2023
Merged
14 tasks
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 16, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HorrorTroll @drashna