Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless "ifdef KEYBOARD_*" #20078

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Remove useless "ifdef KEYBOARD_*" #20078

merged 3 commits into from
Mar 16, 2023

Conversation

fauxpark
Copy link
Member

Description

Getting rid of a bunch of empty files. There are more, I was just looking at boards which had the #if defined(KEYBOARD_etc) crap for including rev headers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 10, 2023 08:11
tzarc
tzarc approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA1's are all identical.

@tzarc tzarc merged commit 9dbee3e into qmk:develop Mar 16, 2023
@fauxpark fauxpark deleted the remove-useless-headers branch March 16, 2023 09:32
@fauxpark fauxpark mentioned this pull request Mar 17, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @tzarc @coquizen
Remove useless "ifdef KEYBOARD_*" (qmk#20078)
b0b0a43 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc