Fix rgblight layers when animations aren't enabled #20097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR qmk#18338 introduced a change that deferred rgblight_set after a call to rgblight_set_layer_state to the next invocation of rgblight_task. However, rgblight_task is a no-op unless RGBLIGHT_USE_TIMER is set, which only happens automatically if an RGB animation is enabled, or if RGBLIGHT_LAYER_BLINK is enabled. If neither of these are enabled, rgblight_set is never called automatically after rgblight_set_layer_state, so the LED state is never actually set. This commit fixes this issue by ensuring that RGBLIGHT_USER_TIMER is set if rgblight layers are enabled.
drashna
approved these changes
Mar 14, 2023
sigprof
approved these changes
Mar 25, 2023
daskygit
approved these changes
Mar 26, 2023
nicsuzor
pushed a commit
to nicsuzor/qmk_firmware
that referenced
this pull request
Mar 28, 2023
mgor
pushed a commit
to mgor/qmk_firmware
that referenced
this pull request
Apr 15, 2023
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #18338 introduced a change that deferred rgblight_set after a call to rgblight_set_layer_state to the next invocation of rgblight_task.
However, rgblight_task is a no-op unless RGBLIGHT_USE_TIMER is set, which only happens automatically if an RGB animation is enabled, or if RGBLIGHT_LAYER_BLINK is enabled.
If neither of these are enabled, rgblight_set is never called automatically after rgblight_set_layer_state, so the LED state is never actually set.
This commit fixes this issue by ensuring that RGBLIGHT_USER_TIMER is set if rgblight layers are enabled.
Types of Changes
Issues Fixed or Closed by This PR
Checklist