Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Binepad BN009 R1 and R2 into common folder #20113

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

vinorodrigues
Copy link
Contributor

@vinorodrigues vinorodrigues commented Mar 13, 2023

Description

This PR is intended for the develop branch as it's deemed a breaking change (insofar as moving folders).

This PR consolidates the Binepad BN009 R1 (ft. a ATMega32U4 mcu) and R2 (ft. the PCB upgrade to the STM32F103 mcu) into a single folder. The two keypads feature the same VID/PID, same matrix grid, and same keymap.

Further cleanup has been performed on the original KB, keyboards/binepad/bn009, now moved to the keyboards/binepad/bn009/r1 folder:

  • config.h and rules.mk settings moved to info.json to enable data-driven compile.
  • default and via kemaps moved to keymap.json for data-driven keymaps.

Folder items in keyboards/binepad/bn009r2 have been moved to keyboards/binepad/bn009/r2 and common items merged in.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

(n/a)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 13, 2023
keyboards/binepad/bn009/readme.md Outdated Show resolved Hide resolved
keyboards/binepad/bn009/r1/config.h Outdated Show resolved Hide resolved
keyboards/binepad/bn009/r1/Info.json Outdated Show resolved Hide resolved
@vinorodrigues vinorodrigues marked this pull request as ready for review March 13, 2023 14:54
@vinorodrigues vinorodrigues requested a review from fauxpark March 13, 2023 14:54
@drashna drashna merged commit bb53e9d into qmk:develop Mar 21, 2023
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@vinorodrigues vinorodrigues deleted the vr-binepad-bn009-consolidate branch April 3, 2023 05:13
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants