Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have enabled a few more effects for my keyboard and the list of effects that is selectable in the VIA frontend does not match the effects in the firmware any longer.
Since the enum
rgb_matrix_effects
is highly dynamic and depends on the specific keyboard/keymap and can also configured on various levels it is best to directly parse theenum
that is the result of the preprocessor and the input of the compiler.This is achieved by also emitting the temporary files (
.i
) when building a firmware. These files can then later be consumed by other tools, in this case with a new subcommand inqmk
.Example output:
This can then be copied into the VIA json as the options list for
id_qmk_rgb_matrix_effect
.@lalalademaxiya1 pinging you as the keychron VIA json files are often brought up as a reference. Maybe you have a similar tool
and/or would benefit from this.
Types of Changes
Issues Fixed or Closed by This PR
Checklist