[Keyboard] Add fpad #20200

td2sk · 2023-03-21T00:12:01Z

Description

Add open source macro keyboard fpad

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- To support custom encoders, copy quantum/encoder.c to the keyboard-specific directory without modification - Following commits will update this file

github-actions · 2023-06-13T02:02:49Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2023-08-01T01:59:18Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

drashna · 2023-06-13T07:34:49Z

keyboards/td2sk/fpad/encoder.c

This looks to mostly just be a copy of the encoder code from core.

It really shouldn't be copied like this, as this is not maintainable.

Also: #21548

keyboards/td2sk/fpad/info.json

dunk2k · 2023-08-18T23:19:14Z

keyboards/td2sk/fpad/rules.mk

@@ -0,0 +1 @@
+LTO_ENABLE = yes


migrate to info.json

Suggested change

LTO_ENABLE = yes

# File is intentionally blank

dunk2k · 2023-08-18T23:20:12Z

keyboards/td2sk/fpad/info.json

+        "joystick": true,
+        "nkro": true,
+        "rgb_matrix": true
+    },


migrated from rules.mk

Suggested change

},

},

"build": {

"lto": true

},

dunk2k · 2023-08-18T23:23:44Z

keyboards/td2sk/fpad/info.json

+    "bootloader": "caterina",
+    "diode_direction": "COL2ROW",
+    "features": {
+        "bootmagic": true,
+        "command": false,
+        "console": false,
+        "extrakey": true,
+        "mousekey": true,
+        "encoder": true,
+        "encoder_map": true,
+        "joystick": true,
+        "nkro": true,
+        "rgb_matrix": true
+    },
+    "matrix_pins": {
+        "cols": ["D3", "D2", "D4", "C6", "NO_PIN"],
+        "rows": ["NO_PIN", "D7", "E6", "B4", "B5"]
+    },
+    "matrix_size": {
+        "cols": 5,
+        "rows": 5
+    },
+    "processor": "atmega32u4",


replace processor and bootloader with development_board

Suggested change

"bootloader": "caterina",

"diode_direction": "COL2ROW",

"features": {

"bootmagic": true,

"command": false,

"console": false,

"extrakey": true,

"mousekey": true,

"encoder": true,

"encoder_map": true,

"joystick": true,

"nkro": true,

"rgb_matrix": true

},

"matrix_pins": {

"cols": ["D3", "D2", "D4", "C6", "NO_PIN"],

"rows": ["NO_PIN", "D7", "E6", "B4", "B5"]

},

"matrix_size": {

"cols": 5,

"rows": 5

},

"processor": "atmega32u4",

"development_board": "promicro",

"diode_direction": "COL2ROW",

"features": {

"bootmagic": true,

"command": false,

"console": false,

"extrakey": true,

"mousekey": true,

"encoder": true,

"encoder_map": true,

"joystick": true,

"nkro": true,

"rgb_matrix": true

},

"matrix_pins": {

"cols": ["D3", "D2", "D4", "C6", "NO_PIN"],

"rows": ["NO_PIN", "D7", "E6", "B4", "B5"]

},

"matrix_size": {

"cols": 5,

"rows": 5

},

dunk2k · 2023-08-18T23:25:39Z

keyboards/td2sk/fpad/info.json

+        "extrakey": true,
+        "mousekey": true,
+        "encoder": true,
+        "encoder_map": true,


can this setting be enabled in rules.mk for each keymap

Suggested change

"encoder_map": true,

drashna · 2023-08-30T07:20:01Z

keyboards/td2sk/fpad/post_rules.mk

@@ -0,0 +1,20 @@
+ifeq ($(strip $(ENCODER_ENABLE)), yes)


as a heads up, this probably won't be accepted in it's current form, due to the custom/duplicated encoder code.

Namely, there is a pending change to add support for custom encoder support, and that should (much) better handle this sort of scenario:
#21548

I understand. I will fix this pull request after the custom encoder feature is merged into QMK.

keyboards/td2sk/fpad/keymaps/via/keymap.c

drashna · 2023-08-30T07:23:10Z

keyboards/td2sk/fpad/post_rules.mk

+
+ifeq ($(strip $(RGB_MATRIX_ENABLE)), yes)
+	RGB_MATRIX_DRIVER = custom
+	SRC += ws2812.c drivers/is31fl3208.c drivers/xl9555.c


wait, is the rgb matrix driver also using the xl9555 driver?

XL9555 is used for the rotary encoder. It is my mistake to enable it for the RGB matrix. I'll fix this.

github-actions · 2023-10-15T01:49:53Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

Co-authored-by: Drashna Jaelre <drashna@live.com>

github-actions · 2023-12-04T01:49:48Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions · 2024-01-04T01:49:22Z

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

td2sk added 9 commits March 21, 2023 08:46

generate new-keyboard directory

e4e1e69

copy original encoder.c to keyboard-specific directory

298928a

- To support custom encoders, copy quantum/encoder.c to the keyboard-specific directory without modification - Following commits will update this file

support custom encoders

f36e208

support via

278028a

support additional buttons

6cb8d5e

support rgb matrix

326257b

update info

1eedac2

improve feature support

fb852fc

update layout

d64d0d8

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 21, 2023

fix include file names to lowercase

24d41e5

github-actions bot added stale Issues or pull requests that have become inactive without resolution. and removed stale Issues or pull requests that have become inactive without resolution. labels Jun 13, 2023

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 1, 2023

drashna reviewed Aug 12, 2023

View reviewed changes

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 13, 2023

dunk2k suggested changes Aug 18, 2023

View reviewed changes

drashna requested changes Aug 30, 2023

View reviewed changes

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2023

td2sk and others added 3 commits October 19, 2023 22:45

Update keyboards/td2sk/fpad/info.json

27f125f

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>

Update keyboards/td2sk/fpad/keymaps/via/keymap.c

4440775

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/td2sk/fpad/keymaps/via/keymap.c

20e66b6

Co-authored-by: Drashna Jaelre <drashna@live.com>

github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 20, 2023

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 4, 2023

github-actions bot closed this Jan 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyboard] Add fpad #20200

[Keyboard] Add fpad #20200

td2sk commented Mar 21, 2023

github-actions bot commented Jun 13, 2023

github-actions bot commented Aug 1, 2023

drashna Jun 13, 2023

dunk2k Aug 18, 2023

dunk2k Aug 18, 2023

dunk2k Aug 18, 2023

dunk2k Aug 18, 2023

drashna Aug 30, 2023

td2sk Oct 19, 2023

drashna Aug 30, 2023

td2sk Oct 19, 2023

github-actions bot commented Oct 15, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Jan 4, 2024

-    },
+    },
+    "build": {
+        "lto": true
+    },

[Keyboard] Add fpad #20200

[Keyboard] Add fpad #20200

Conversation

td2sk commented Mar 21, 2023

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

github-actions bot commented Jun 13, 2023

github-actions bot commented Aug 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 15, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Jan 4, 2024