Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WS2812_DRIVER to data driven #20248

Merged
merged 6 commits into from
Mar 26, 2023
Merged

Move WS2812_DRIVER to data driven #20248

merged 6 commits into from
Mar 26, 2023

Conversation

fauxpark
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 24, 2023 03:51
@drashna drashna requested a review from a team March 25, 2023 00:31
@fauxpark
Copy link
Member Author

SHA1s match.

@fauxpark fauxpark merged commit 36ce81d into qmk:develop Mar 26, 2023
@fauxpark fauxpark deleted the ws2812-driver-data-driven branch March 26, 2023 07:22
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@fauxpark @nicsuzor
Move WS2812_DRIVER to data driven (qmk#20248)
131b390
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @coquizen
Move WS2812_DRIVER to data driven (qmk#20248)
369628f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna