Added Keyboard Lotus58Glow #20281
Closed
Added Keyboard Lotus58Glow #20281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atmel-dfu to atmeldfu
waffle87
requested changes
Mar 29, 2023
There was a problem hiding this comment.
- All my same suggestions made to the
atmeldfudirectory also need to be applied tocaterinaandnanobootdirectories. - It would be preferable to have a top level
info.jsonfile with code that applies to all versions, theninfo.jsonfiles in sub directories with things that differ. Same goes for keymaps. Here's a good reference.
| "build": { | ||
| "lto": true | ||
| }, | ||
| "debounce": 5, |
There was a problem hiding this comment.
Suggested change
| "debounce": 5, |
Comment on lines
+71
to
+137
| // Rotate OLED to fit vertical placement. DO NOT EDIT! | ||
| oled_rotation_t oled_init_kb(oled_rotation_t rotation) { | ||
|
|
||
| if (is_keyboard_left()) { | ||
| return OLED_ROTATION_90; | ||
| } | ||
| return OLED_ROTATION_270; | ||
| } | ||
|
|
||
| // Renders default QMK Logo. DO NOT EDIT! | ||
| void render_logo(void) { | ||
| static const char PROGMEM qmk_logo[] = { | ||
| 0x80, 0x81, 0x82, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89, 0x8A, 0x8B, 0x8C, 0x8D, 0x8E, 0x8F, 0x90, 0x91, 0x92, 0x93, 0x94, | ||
| 0xA0, 0xA1, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xAB, 0xAC, 0xAD, 0xAE, 0xAF, 0xB0, 0xB1, 0xB2, 0xB3, 0xB4, | ||
| 0xC0, 0xC1, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9, 0xCA, 0xCB, 0xCC, 0xCD, 0xCE, 0xCF, 0xD0, 0xD1, 0xD2, 0xD3, 0xD4, 0x00 | ||
| }; | ||
| oled_write_P(qmk_logo, false); | ||
| } | ||
|
|
||
| static void print_status_narrow(void) { | ||
| // Create OLED content | ||
| oled_write_P(PSTR("\n"), false); | ||
| oled_write_P(PSTR(""), false); | ||
| oled_write_P(PSTR("Lotus -58-"), false); | ||
| oled_write_P(PSTR("\n"), false); | ||
|
|
||
| // Print current layer | ||
| oled_write_P(PSTR("Layer"), false); | ||
| switch (get_highest_layer(layer_state)) { | ||
| case 0: | ||
| oled_write_P(PSTR("-Base\n"), false); | ||
| break; | ||
| case 1: | ||
| oled_write_P(PSTR("-Num \n"), false); | ||
| break; | ||
| case 2: | ||
| oled_write_P(PSTR("-Func\n"), false); | ||
| break; | ||
| case 3: | ||
| oled_write_P(PSTR("-Sys \n"), false); | ||
| break; | ||
| default: | ||
| oled_write_P(PSTR("Undef"), false); | ||
| } | ||
|
|
||
| // Display autoshift | ||
| oled_write_P(PSTR("\n"), false); | ||
| led_t led_usb_state = host_keyboard_led_state(); | ||
| oled_write_ln_P(PSTR("Caps- lock"), led_usb_state.caps_lock); | ||
| bool autoshift = get_autoshift_state(); | ||
| oled_write_P(PSTR("\n"), false); | ||
| oled_write_P(PSTR("Auto-Shift"), autoshift); | ||
| oled_write_P(PSTR("\n"), false); | ||
|
|
||
| } | ||
|
|
||
| bool oled_task_user(void) { | ||
| // Render the OLED | ||
| if (is_keyboard_left()) { | ||
| print_status_narrow(); | ||
| //render_logo(); | ||
| } else { | ||
| print_status_narrow(); | ||
| //render_logo(); | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Ideally, this should be removed from all the keymaps, and placed in lotus58.c file using the correct _kb functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started over from scratch and added Lotus 58 Glow default firmware
Types of Changes
Checklist