Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing_heatmap: Add macro to configure increase steps #20300

Merged
merged 2 commits into from
Apr 30, 2023
Merged

typing_heatmap: Add macro to configure increase steps #20300

merged 2 commits into from
Apr 30, 2023

Conversation

nachtjasmin
Copy link
Contributor

Description

There are a lot of configuration values for configuring the cooldown of the heatmap. However, for fast typers, the process of heating up might be too fast. Right now, manual changes to the codebase were necessary which in turn require to understand it first.

By defining a macro and allowing to override it, it's now easier to adjust this value as wanted.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

There are a lot of configuration values for configuring the cooldown of
the heatmap. However, for fast typers, the process of heating up might
be too fast. Right now, manual changes to the codebase were necessary
which in turn require to understand it first.

By defining a macro and allowing to override it, it's now easier to
adjust this value as wanted.
@zvecr zvecr changed the base branch from master to develop March 30, 2023 17:24
docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
Co-authored-by: Joel Challis <git@zvecr.com>
@drashna drashna requested a review from a team April 4, 2023 21:16
@tzarc tzarc merged commit 4887f03 into qmk:develop Apr 30, 2023
@nachtjasmin nachtjasmin deleted the typing-heatmap-increase-configuration branch April 30, 2023 07:12
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants