Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add zoom75 wired #20396

Merged
merged 17 commits into from
Apr 16, 2023
Merged

[Keyboard] Add zoom75 wired #20396

merged 17 commits into from
Apr 16, 2023

Conversation

spbgzh
Copy link
Contributor

@spbgzh spbgzh commented Apr 10, 2023

Description

add new keyboard zoom75

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 10, 2023
keyboards/meletrix/zoom75/config.h Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/zoom75.h Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/readme.md Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/readme.md Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/rules.mk Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/zoom75.c Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/info.json Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@spbgzh
Copy link
Contributor Author

spbgzh commented Apr 10, 2023

Thanks, all suggestions are fixde.

keyboards/meletrix/zoom75/config.h Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/zoom75.h Outdated Show resolved Hide resolved
@spbgzh spbgzh requested review from adophoxia and elpekenin April 10, 2023 01:25
@spbgzh spbgzh mentioned this pull request Apr 10, 2023
7 tasks
keyboards/meletrix/zoom75/config.h Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/default/rule.mk Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/meletrix/zoom75/zoom75.c Outdated Show resolved Hide resolved
@spbgzh spbgzh requested a review from waffle87 April 10, 2023 12:03
@@ -0,0 +1,27 @@
# zoom75

More Info at [meletrix](https://meletrix.com/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify here how this sits/interacts with the bluetooth hardware, to avoid inevitable confusion.

Copy link
Contributor Author

@spbgzh spbgzh Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either, I am just a college student, I write single mode version.😂 Bluetooth version solutions should be provided by third-party contractors. And they provided screen solutions too. I'm also curious about how to realize Bluetooth n-keys.
🤨

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in that case, you'd probably want to add text specifying that this entry for the Zoom75 is only for the wired variant and not for the BT/Tri-mode variant, so as to not add confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, specified version.

@spbgzh spbgzh changed the title add new keyboard zoom75 add new keyboard zoom75 wired version Apr 12, 2023
@spbgzh spbgzh requested a review from keyboard-magpie April 12, 2023 01:47
@waffle87 waffle87 changed the title add new keyboard zoom75 wired version [Keyboard] Add zoom75 wired Apr 16, 2023
@waffle87 waffle87 merged commit 6e5ff01 into qmk:master Apr 16, 2023
sudish added a commit to sudish/qmk_firmware that referenced this pull request Apr 16, 2023
* upstream/master: (73 commits)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
  Add hardware information momokai keyboards (qmk#20434)
  4pplet/eagle_viper_rep/rev_a Layout Macro Conversion and Additions (qmk#20414)
  [Keymap] Add paulomp90 lily58 keymap (qmk#20327)
  [Keymap] Add personal keymap for Lily58 (qmk#18735)
  [Keyboard] Fix h87 g2 VID conflict (qmk#20388)
  [Keymap] PHSC138 Keymap for Atom47 (qmk#18768)
  [Keyboard] add kb2040 flavor of gherkin (qmk#18360)
  [Keyboard] ymdk/id75 (qmk#19967)
  fixing bug that caused KC_DEL and KC_MUTE (encoder press) to be swapped (qmk#20420)
  4pplet/bootleg/rev_a Layout Macro Conversion and Addition (qmk#20400)
  4pplet/aekiso60 Layout Macro Conversion and Additions (qmk#20399)
  Reject info.json at keymap level (qmk#20408)
  Bump anothrNick/github-tag-action from 1.61.0 to 1.62.0 (qmk#20407)
  [Keyboard] Update angle65 VID/PID (qmk#20401)
  ...
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request Apr 18, 2023
quangd42 pushed a commit to quangd42/qmk_firmware that referenced this pull request Apr 20, 2023
queyenth pushed a commit to queyenth/qmk_firmware that referenced this pull request Apr 21, 2023
stratosgear pushed a commit to stratosgear/qmk_firmware that referenced this pull request Apr 26, 2023
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
SjB added a commit to SjB/qmk_firmware that referenced this pull request May 12, 2023
* master:
  NK Plus (qmk#20392)
  [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512)
  [Docs] Remove combo count from array (qmk#20511)
  Add QuadrumLabs Delta (qmk#20409)
  Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486)
  GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476)
  Fix typo in `feature_wpm.md` title (qmk#20464)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants