Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoder map for Iris Rev. 5 VIA #20412

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Add encoder map for Iris Rev. 5 VIA #20412

merged 3 commits into from
Apr 19, 2023

Conversation

nooges
Copy link
Member

@nooges nooges commented Apr 11, 2023 •
edited
Loading

Description

Change PID to add support for encoder mapping in VIA for Iris Rev. 5. Also cleanup PID forks for Rev. 6.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nooges nooges mentioned this pull request Apr 11, 2023
Merged
7 tasks
fauxpark
fauxpark reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard updates should go to develop.

@nooges nooges force-pushed the iris-rev5-via-encoder-map branch from 7c6be4b to d600dbd Compare April 11, 2023 17:31
@nooges nooges force-pushed the iris-rev5-via-encoder-map branch from c3a62fb to 548c028 Compare April 11, 2023 17:37
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Apr 11, 2023
@nooges nooges changed the base branch from master to develop April 11, 2023 19:16
@drashna
Copy link
Member

drashna commented Apr 14, 2023

bunch of merge conflicts

@nooges nooges force-pushed the iris-rev5-via-encoder-map branch from 548c028 to 618e7c5 Compare April 18, 2023 20:39
@nooges
Copy link
Member Author

nooges commented Apr 18, 2023

bunch of merge conflicts

Fixed up the merge conflicts now

@nooges nooges merged commit 9f492f6 into qmk:develop Apr 19, 2023
@nooges nooges deleted the iris-rev5-via-encoder-map branch April 19, 2023 15:21
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@nooges @coquizen
Add encoder map for Iris Rev. 5 VIA (qmk#20412)
5521918
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@nooges @autoferrit
Add encoder map for Iris Rev. 5 VIA (qmk#20412)
de9c071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nooges @drashna @fauxpark @keyboard-magpie