Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk find: usability improvements #20440

Merged
merged 3 commits into from
May 20, 2023
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 13, 2023

Description

  • Force rules.mk files to be read as UTF-8 (default is CP1252 on Windows, causes issues with Unicode characters)
  • qmk find: Add --print argument to print the value of the given key(s) for each matched target
  • qmk find: Reworked the filtering a little to add support for length(key, value), contains(key, value), and absent(key). Could probably be refactored further, maybe add !=?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 13, 2023 10:00
@tzarc tzarc merged commit 102c42b into qmk:develop May 20, 2023
@fauxpark fauxpark deleted the qmk-find-improvements branch May 20, 2023 14:57
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants