Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEBoards Satellite Rev1 Layout Macro Conversion #20442

Merged
merged 3 commits into from
Apr 16, 2023
Merged

AEBoards Satellite Rev1 Layout Macro Conversion #20442

merged 3 commits into from
Apr 16, 2023

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Apr 13, 2023 •
edited
Loading

Description

  • converts layout macro to data-driven configuration and renames it to LAYOUT_65_ansi_rwkl
    • only one layout is supported

cc @Xelus22 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    • via keymap results in an error for me due to file size, but my environment has an ancient avr-gcc, so problem for a future me. via keymap compiles after base branch changed to develop (2 bytes free!). I should still work on updating avr-gcc.
    • default keymap was shasum-verified before and after.

@noroadsleft noroadsleft requested a review from a team April 13, 2023 18:01
Xelus22
Xelus22 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drashna drashna requested a review from a team April 15, 2023 09:47
@noroadsleft noroadsleft force-pushed the kb_layouts/aeboards_satellite branch from e35c5a8 to 008a798 Compare April 16, 2023 21:51
@noroadsleft noroadsleft changed the base branch from master to develop April 16, 2023 21:51
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Apr 16, 2023
@noroadsleft
Copy link
Member Author

Changed base branch to develop to avoid merge conflicts with some other work going on in QMK.

@noroadsleft noroadsleft merged commit 8a4867e into qmk:develop Apr 16, 2023
@noroadsleft noroadsleft deleted the kb_layouts/aeboards_satellite branch April 16, 2023 23:20
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
AEBoards Satellite Rev1 Layout Macro Conversion (qmk#20442)
02cbdf0 
* add matrix_diagram.md

* rename LAYOUT_all to LAYOUT_65_ansi_rwkl

* info.json: apply friendly formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @Xelus22