Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIOI G60 Layout Macro Additions #20498

Merged
merged 10 commits into from
Apr 23, 2023
Merged

Conversation

noroadsleft
Copy link
Member

Description

  • adds six new layout macros
  • minor touch-up to LAYOUT_all and keymaps
  • add layout/matrix diagram

cc @scottywei (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 18, 2023
@noroadsleft noroadsleft requested a review from a team April 18, 2023 21:17
@drashna drashna requested a review from a team April 22, 2023 08:18
@noroadsleft noroadsleft merged commit a6e2435 into qmk:develop Apr 23, 2023
@noroadsleft noroadsleft deleted the kb_layouts/bioi_g60 branch April 23, 2023 02:04
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* grid align keycodes in keymaps

* physically arrange layout macro

The switch positions available for matrix position [3, 13] are both to the left of the only position present for matrix position [4, 7]. This commit switches the two locations physically and in the keymaps.

* add LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi_arrow

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_iso_split_bs_rshift

* add LAYOUT_60_iso_arrow

* add LAYOUT_60_tsangan_hhkb_iso
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* grid align keycodes in keymaps

* physically arrange layout macro

The switch positions available for matrix position [3, 13] are both to the left of the only position present for matrix position [4, 7]. This commit switches the two locations physically and in the keymaps.

* add LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi_arrow

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_iso_split_bs_rshift

* add LAYOUT_60_iso_arrow

* add LAYOUT_60_tsangan_hhkb_iso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants