Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CannonKeys Balance Layout Macro Additions and Touch-Up #20548

Merged
merged 8 commits into from
Apr 25, 2023
Merged

CannonKeys Balance Layout Macro Additions and Touch-Up #20548

merged 8 commits into from
Apr 25, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds four new layout macros with reference keymaps
  • adds layout/matrix diagram
  • refactors and standardizes keymaps

cc @awkannan (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 24, 2023
@noroadsleft noroadsleft requested a review from a team April 24, 2023 15:32
@noroadsleft noroadsleft merged commit 72c66cd into qmk:develop Apr 25, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cannonkeys_balance branch April 25, 2023 17:40
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
CannonKeys Balance Layout Macro Additions and Touch-Up (qmk#20548)
f061741 
* add matrix_diagram.md

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* info.json: apply friendly formatting

* standardize default and via keymaps

Place the `KC_NUHS` and `KC_NUBS` keycodes on the correct keys.

* add LAYOUT_ansi with reference keymap

* add LAYOUT_ansi_split_bs with reference keymap

* add LAYOUT_iso with reference keymap

* add LAYOUT_iso_split_bs with reference keymap
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
CannonKeys Balance Layout Macro Additions and Touch-Up (qmk#20548)
6e21a7c 
* add matrix_diagram.md

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* info.json: apply friendly formatting

* standardize default and via keymaps

Place the `KC_NUHS` and `KC_NUBS` keycodes on the correct keys.

* add LAYOUT_ansi with reference keymap

* add LAYOUT_ansi_split_bs with reference keymap

* add LAYOUT_iso with reference keymap

* add LAYOUT_iso_split_bs with reference keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @waffle87