Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CherryB Studio CB87v2 Layout Macro Additions #20597

Merged
merged 12 commits into from
Apr 28, 2023
Merged

CherryB Studio CB87v2 Layout Macro Additions #20597

merged 12 commits into from
Apr 28, 2023

Conversation

noroadsleft
Copy link
Member

@noroadsleft noroadsleft commented Apr 27, 2023 •
edited
Loading

Description

  • adds eight new layout macros
  • enables Community Layout support
  • adds layout/matrix diagram

cc @lunaticwhat (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 27, 2023 17:10
@noroadsleft
correct listed maintainer
639e8ed 
Maintainer has changed their GitHub username.
@drashna drashna requested a review from a team April 27, 2023 20:27
@noroadsleft noroadsleft merged commit a09453f into qmk:develop Apr 28, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cherrybstudio_cb87v2 branch April 28, 2023 04:23
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
CherryB Studio CB87v2 Layout Macro Additions (qmk#20597)
0bdc1e5 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support

* correct listed maintainer

Maintainer has changed their GitHub username.
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
CherryB Studio CB87v2 Layout Macro Additions (qmk#20597)
e7303a6 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support

* correct listed maintainer

Maintainer has changed their GitHub username.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark