Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E88 Layout Macro Additions #20612

Merged
merged 13 commits into from
Apr 29, 2023
Merged

E88 Layout Macro Additions #20612

merged 13 commits into from
Apr 29, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds eight new layout macros
  • enables Community Layout support
  • refactors default and via keymaps
  • adds layout/matrix diagram

cc @2-n (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2023
@noroadsleft noroadsleft requested a review from a team April 28, 2023 16:44
fauxpark
fauxpark requested changes Apr 28, 2023
View reviewed changes
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
keyboards/e88/info.json Outdated Show resolved Hide resolved
@noroadsleft @fauxpark
Apply suggestions from code review
5a4856a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@noroadsleft noroadsleft merged commit 8ee863a into qmk:develop Apr 29, 2023
@noroadsleft noroadsleft deleted the kb_layouts/e88 branch April 29, 2023 05:50
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
E88 Layout Macro Additions (qmk#20612)
3885ffd 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor keymaps

- use four-space indent
- grid-align keycodes
- use QMK-native alias for `KC_TRNS`

* add LAYOUT_tkl_f13_ansi

* add LAYOUT_tkl_f13_ansi_split_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_f13_ansi_tsangan_split_rshift

* add LAYOUT_tkl_f13_iso

* add LAYOUT_tkl_f13_iso_split_rshift

* add LAYOUT_tkl_f13_iso_tsangan

* add LAYOUT_tkl_f13_iso_tsangan_split_rshift

* enable Community Layout support

* Apply suggestions from code review
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
E88 Layout Macro Additions (qmk#20612)
f501803 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor keymaps

- use four-space indent
- grid-align keycodes
- use QMK-native alias for `KC_TRNS`

* add LAYOUT_tkl_f13_ansi

* add LAYOUT_tkl_f13_ansi_split_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_f13_ansi_tsangan_split_rshift

* add LAYOUT_tkl_f13_iso

* add LAYOUT_tkl_f13_iso_split_rshift

* add LAYOUT_tkl_f13_iso_tsangan

* add LAYOUT_tkl_f13_iso_tsangan_split_rshift

* enable Community Layout support

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark