Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FJLabs Polaris Layout Additions and Touch-Up #20622

Merged
merged 14 commits into from
Apr 29, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add eight new layout macros
  • enable Community Layout support
  • fix off-by-one error in Configurator implementation
  • refactor keymaps
  • add layout/matrix diagram

cc @mrnoisytiger (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 29, 2023
@noroadsleft noroadsleft requested a review from a team April 29, 2023 09:10
@noroadsleft noroadsleft merged commit d5d1f16 into qmk:develop Apr 29, 2023
@noroadsleft noroadsleft deleted the kb_layouts/fjlabs_polaris branch April 29, 2023 17:48
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* refactor keymaps

* fix Configurator implementation

The original C-based code had an off-by-one error in the key sequence, that was then converted in data-driven configurator without being corrected.

* info.json: apply friendly formatting

* add LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_iso_split_bs_rshift

* add LAYOUT_60_iso

* add LAYOUT_60_iso_tsangan_split_bs_rshift

* add LAYOUT_60_iso_tsangan

* enable Community Layout support

* edit keyboard maintainer
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* refactor keymaps

* fix Configurator implementation

The original C-based code had an off-by-one error in the key sequence, that was then converted in data-driven configurator without being corrected.

* info.json: apply friendly formatting

* add LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_iso_split_bs_rshift

* add LAYOUT_60_iso

* add LAYOUT_60_iso_tsangan_split_bs_rshift

* add LAYOUT_60_iso_tsangan

* enable Community Layout support

* edit keyboard maintainer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants