Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrayStudio Aero 75 Refactor and Touch-Up #20640

Merged
merged 5 commits into from
Apr 30, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_all to LAYOUT_ansi_blocker
  • refactor keymaps
  • flesh-out keyboard readme
  • add layout/matrix diagram

The existing codebase only supports the Hotswap PCB, and the matrix diagram and readme reflect this.

cc @edwardslau (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Existing codebase only supports the Hotswap version, but there is a Soldered version that supports additional layouts.
- use four-space indent
- update grid-alignment of keycodes
- remove trailing spaces
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 30, 2023
@noroadsleft noroadsleft requested a review from a team April 30, 2023 06:32
@noroadsleft noroadsleft merged commit 3bc4aea into qmk:develop Apr 30, 2023
@noroadsleft noroadsleft deleted the kb_layouts/gray_studio_aero75 branch April 30, 2023 21:21
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_ansi_blocker

Existing codebase only supports the Hotswap version, but there is a Soldered version that supports additional layouts.

* refactor keymaps

- use four-space indent
- update grid-alignment of keycodes
- remove trailing spaces

* flesh-out keyboard readme
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_ansi_blocker

Existing codebase only supports the Hotswap version, but there is a Soldered version that supports additional layouts.

* refactor keymaps

- use four-space indent
- update grid-alignment of keycodes
- remove trailing spaces

* flesh-out keyboard readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants