Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take care of scroll divisor remainders for PS/2 drag scroll #20732

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Take care of scroll divisor remainders for PS/2 drag scroll #20732

merged 2 commits into from
Sep 25, 2023

Conversation

dkao
Copy link
Contributor

@dkao dkao commented May 5, 2023

Description

Similar to drag scroll implementations elsewhere, accumulate the X & Y coordinates until enough for a wheel tick. Save and apply the remainder towards next wheel tick.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 5, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 30, 2023
@dkao
Copy link
Contributor Author

dkao commented Sep 2, 2023 •
edited
Loading

This change is ready, I've been using it for a smoother trackpoint drag scroll.

IMO it makes sense to merge this before PS/2 mouse is eventually converted to pointing device.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Sep 3, 2023
@wolfwood
Copy link

wolfwood commented Sep 5, 2023

fwiw, looks good to me

@drashna drashna requested a review from a team September 14, 2023 08:21
@tzarc tzarc merged commit f35dee5 into qmk:develop Sep 25, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@dkao @mechlovin
Take care of scroll divisor remainders for PS/2 drag scroll (qmk#20732)
02968d0
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@dkao @christrotter
Take care of scroll divisor remainders for PS/2 drag scroll (qmk#20732)
462eb09
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@dkao @zgagnon
Take care of scroll divisor remainders for PS/2 drag scroll (qmk#20732)
a8b0eff
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@dkao
Take care of scroll divisor remainders for PS/2 drag scroll (qmk#20732)
f3997f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkao @wolfwood @drashna @tzarc