Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ramlord WITF Layout Touch-Up and Addition #20783

Merged
merged 5 commits into from
May 9, 2023
Merged

Ramlord WITF Layout Touch-Up and Addition #20783

merged 5 commits into from
May 9, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add one new layout macro
  • add a missing position to LAYOUT_all (breaks compatibility with out-of-tree keymaps)
  • fix layout data
  • add layout/matrix diagram

cc @Sleepdealr (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft added 5 commits May 6, 2023 20:46
@noroadsleft
add matrix_diagram.md
83d4f27
@noroadsleft
info.json: apply friendly formatting
700142b
@noroadsleft
info.json: fix key overlap
c3c7b13 
Fixes the Numpad Enter key overlapping the second Numpad 0 key (bottom right of numpad).
@noroadsleft
info.json: add matrix position [7, 1]
4eb066a 
Adds matrix position [7, 1] to the layout data (bottom half of split Numpad Plus).
@noroadsleft
add LAYOUT_2u_bs_275u_rshift
d624ff5
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 8, 2023
@noroadsleft noroadsleft requested a review from a team May 8, 2023 07:43
@noroadsleft noroadsleft merged commit 0556a6a into qmk:develop May 9, 2023
@noroadsleft noroadsleft deleted the kb_layouts/ramlord_witf branch May 9, 2023 02:30
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Ramlord WITF Layout Touch-Up and Addition (qmk#20783)
3a12809 
* add matrix_diagram.md

* info.json: apply friendly formatting

* info.json: fix key overlap

Fixes the Numpad Enter key overlapping the second Numpad 0 key (bottom right of numpad).

* info.json: add matrix position [7, 1]

Adds matrix position [7, 1] to the layout data (bottom half of split Numpad Plus).

* add LAYOUT_2u_bs_275u_rshift
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Ramlord WITF Layout Touch-Up and Addition (qmk#20783)
73502c4 
* add matrix_diagram.md

* info.json: apply friendly formatting

* info.json: fix key overlap

Fixes the Numpad Enter key overlapping the second Numpad 0 key (bottom right of numpad).

* info.json: add matrix position [7, 1]

Adds matrix position [7, 1] to the layout data (bottom half of split Numpad Plus).

* add LAYOUT_2u_bs_275u_rshift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark