Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rart67 Layout Additions #20786

Merged
merged 11 commits into from
May 9, 2023
Merged

Rart67 Layout Additions #20786

merged 11 commits into from
May 9, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_all to LAYOUT_65_ansi_rwkl_split_bs
  • add five new layout macros
  • enable Community Layout support
  • add layout/matrix diagram

cc @alabahuy (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 8, 2023
@noroadsleft noroadsleft requested a review from a team May 8, 2023 07:57
fauxpark
fauxpark requested changes May 8, 2023
View reviewed changes
keyboards/rart/rart67/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart67/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart67/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart67/info.json Outdated Show resolved Hide resolved
keyboards/rart/rart67/info.json Outdated Show resolved Hide resolved
@noroadsleft @fauxpark
Apply suggestions from code review
f79db3c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@noroadsleft noroadsleft merged commit 8c879b9 into qmk:develop May 9, 2023
@noroadsleft noroadsleft deleted the kb_layouts/rart_rart67 branch May 9, 2023 06:11
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Rart67 Layout Additions (qmk#20786)
41156b5 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor default and via keymaps

- four-space indent
- grid-align keycodes

* rename LAYOUT_all to LAYOUT_65_ansi_rwkl_split_bs

* add LAYOUT_65_ansi_rwkl

* add LAYOUT_65_ansi_blocker_split_bs

* add LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan_split_bs

* add LAYOUT_65_ansi_blocker_tsangan

* enable Community Layout support

* Apply suggestions from code review
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Rart67 Layout Additions (qmk#20786)
d90cb8a 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor default and via keymaps

- four-space indent
- grid-align keycodes

* rename LAYOUT_all to LAYOUT_65_ansi_rwkl_split_bs

* add LAYOUT_65_ansi_rwkl

* add LAYOUT_65_ansi_blocker_split_bs

* add LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan_split_bs

* add LAYOUT_65_ansi_blocker_tsangan

* enable Community Layout support

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark