Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk format-json: Expose full key path and respect sort_keys #20836

Merged
merged 4 commits into from
May 20, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 10, 2023

Description

The info.json encoder now knows the full key path when encoding, instead of just the key name, in the form of an array. One possible application for this would be the ability to differentiate LED layouts from key layouts, possibly allowing further formatting of the latter to separate rows and gaps between keys. This is currently only done by hand and would be reverted by the encoder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sorry, something went wrong.

@fauxpark fauxpark requested a review from a team May 10, 2023 02:25
@tzarc tzarc merged commit 6d90fa2 into qmk:develop May 20, 2023
@fauxpark fauxpark deleted the format-json-sort-and-key-path branch May 20, 2023 14:57
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants