Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RGBLIGHT_DEFAULT_ON macro configuration option #20857

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Add RGBLIGHT_DEFAULT_ON macro configuration option #20857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8719080
ADD RGB_DEFAULT_DISABLED option and updated documentation
Gondolindrim May 11, 2023
2d4e025
Formatting
Gondolindrim May 18, 2023
c253989
Add as by fauxpark's suggestion
Gondolindrim Jun 2, 2023
9d47adb
Formatting
Gondolindrim Jun 2, 2023
9a7c8dd
Use boolean values instead of numerical
Gondolindrim Jun 3, 2023
6bb4ef5
Edit documentation formatting
Gondolindrim Jun 3, 2023
61ba046
Remove comment
Gondolindrim Jun 3, 2023
e8cbc37
Set RGB mode to DEFAULT macro at init
Gondolindrim Jun 3, 2023
0dfe83e
Merge remote-tracking branch 'origin/develop' into rgb_off
zvecr Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/feature_rgblight.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Your RGB lighting can be configured by placing these `#define`s in your `config.
|`RGBLIGHT_DEFAULT_SAT` |`UINT8_MAX` (255) |The default saturation to use upon clearing the EEPROM |
|`RGBLIGHT_DEFAULT_VAL` |`RGBLIGHT_LIMIT_VAL` |The default value (brightness) to use upon clearing the EEPROM |
|`RGBLIGHT_DEFAULT_SPD` |`0` |The default speed to use upon clearing the EEPROM |
|`RGBLIGHT_DEFAULT_ON` |`true` |Enable RGB lighting upon clearing the EEPROM |

## Effects and Animations

Expand Down
6 changes: 5 additions & 1 deletion quantum/rgblight/rgblight.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ static uint8_t mode_base_table[] = {
# define RGBLIGHT_DEFAULT_SPD 0
#endif

#if !defined(RGBLIGHT_DEFAULT_ON)
# define RGBLIGHT_DEFAULT_ON true
#endif

static inline int is_static_effect(uint8_t mode) {
return memchr(static_effect_table, mode, sizeof(static_effect_table)) != NULL;
}
Expand Down Expand Up @@ -195,7 +199,7 @@ void eeconfig_update_rgblight_current(void) {
}

void eeconfig_update_rgblight_default(void) {
rgblight_config.enable = 1;
rgblight_config.enable = RGBLIGHT_DEFAULT_ON;
rgblight_config.velocikey = 0;
rgblight_config.mode = RGBLIGHT_DEFAULT_MODE;
rgblight_config.hue = RGBLIGHT_DEFAULT_HUE;
Expand Down