Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WB32 MCU remote wakeup issue #20863

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Fixed WB32 MCU remote wakeup issue #20863

merged 3 commits into from
Sep 12, 2023

Conversation

itarze
Copy link
Contributor

@itarze itarze commented May 11, 2023

Description

There are some computers that need to add a wait implementation when remote wakeup

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 11, 2023
@itarze
Copy link
Contributor Author

itarze commented May 12, 2023

This PR needs to wait for ChibiOS/ChibiOS-Contrib#367 to be merged before merging

@itarze itarze changed the title [WB32 MCU] Update restart_usb_driver function Fixed WB32 MCU remote wakeup issue May 12, 2023
@drashna drashna added the awaiting_pr Relies on another PR to be merged first label May 13, 2023
@itarze
Copy link
Contributor Author

itarze commented Jul 17, 2023

Review the PR, please.

@drashna drashna requested a review from a team July 27, 2023 03:44
@itarze
Copy link
Contributor Author

itarze commented Jul 27, 2023

chibios-contrib lib needs to be updated.

@lesshonor lesshonor mentioned this pull request Aug 3, 2023
Open
2 tasks
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 11, 2023
@itarze
Copy link
Contributor Author

itarze commented Sep 12, 2023

?

@fauxpark fauxpark requested a review from a team September 12, 2023 05:52
@fauxpark fauxpark added awaiting review and removed awaiting_pr Relies on another PR to be merged first labels Sep 12, 2023
@tzarc tzarc merged commit bd2e59a into qmk:develop Sep 12, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@itarze @mechlovin
Fixed WB32 MCU remote wakeup issue (qmk#20863)
87e4ca1 
Co-authored-by: Joy <chang.li@westberrytech.com>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@itarze @christrotter
Fixed WB32 MCU remote wakeup issue (qmk#20863)
59ce946 
Co-authored-by: Joy <chang.li@westberrytech.com>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@itarze @zgagnon
Fixed WB32 MCU remote wakeup issue (qmk#20863)
dc98318 
Co-authored-by: Joy <chang.li@westberrytech.com>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@itarze
Fixed WB32 MCU remote wakeup issue (qmk#20863)
117e4cc 
Co-authored-by: Joy <chang.li@westberrytech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
awaiting review core stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itarze @tzarc @fauxpark @drashna